shadowwalker / next-pwa

Zero config PWA plugin for Next.js, with workbox 🧰
MIT License
3.75k stars 311 forks source link

Readme not clear: pwa object mentioned, but missing in the code sample #438

Open ezekiel747 opened 1 year ago

ezekiel747 commented 1 year ago

Hi, I believe there are some confusing instructions in README regarding pwa config. It mentions pwa object and i would expect something like

const nextConfig = {
  reactStrictMode: true,
  swcMinify: true,
  pwa: {
    // some options
  }
  ...
}

module.exports = withPWA(nextConfig);

but the code sample that follows is putting the config options elsewhere (there is no pwa object there). Please check the attached screenshot.

image

The link to that part is: https://github.com/shadowwalker/next-pwa#configuration