search

shaduzlabs / cabl

Controller ABstraction Layer
MIT License
128 stars 36 forks source link

Feature/more ext build options #4

Closed bsjones closed 7 years ago

bsjones commented 7 years ago

Heya!

These changes provide a little more flexibility when specifying dependencies. I am currently porting some of my projects to mingw which already has libusb and hidapi available.

So far so good, there is only one more outstanding issue. When using ExternalProject_Add, none of the parent projects settings are passed on. I was thinking of adding a new variable CABL_EXT_CMAKE_ARGS to pass these through the add*() functions. I need this to get around a cmake issue with mingw and to specify the cmake generator (so I can use ninja all round). What do you think?

This change is Reviewable

shaduzlabs commented 7 years ago

well done! And adding the new variable sounds good, just create the PR and I'll merge it :)