search

shaffe-fr / flow-filezilla

Flow launcher plugin to open FileZilla websites
MIT License
2 stars 0 forks source link

Plugin won't install #1

Closed Myxoz closed 6 months ago

Myxoz commented 6 months ago

If I try to install the plugin from the Plugin Store and restart the Flow Launcher, the FileZilla plugin wont display as installed. Instead it will just appear to not be installed correctly, it will just show up in the Plugin Store like it did before and won't show up in the Plugins tab. If I try to reinstall it, it prompts me with: Copying path C:\Users\Laurin\AppData\Local\FlowLauncher\app-1.18.0\UserData\Plugins\FileZilla-1.0.0 has failed, it will now be deleted for consistency If i look in the directory C:\Users\Laurin\AppData\Local\FlowLauncher\app-1.18.0\UserData\Plugins\FileZilla-1.0.0 the folder exists and has content. No matter how many times I reinstall it won't show up in the installed plugins and therefore i am not able to even set the FileZilla execution path. The logs:

EXCEPTION OCCURS: System.ArgumentNullException: Value cannot be null. (Parameter 'path2')
   at void ArgumentNullException.Throw(string paramName)
   at string System.IO.Path.Combine(string path1, string path2)
   at void Flow.Launcher.Plugin.PluginMetadata.set_PluginDirectory(string value) in /_/Flow.Launcher.Plugin/PluginMetadata.cs:line 28
   at PluginMetadata Flow.Launcher.Core.Plugin.PluginConfig.GetPluginMetadata(string pluginDirectory) in C:/projects/flow-launcher/Flow.Launcher.Core/Plugin/PluginConfig.cs:line 113

I'm using a Windows 11 PC

I don't know wether you need to know the full logs, infact this is my first ever issue i posted on GitHub, i hope this is helpful. Full logs (from clicking install to Flow Launcher restart due to new plugin) :

16:22:39.6192+02:00 - INFO  - CommunityPluginSource.FetchAsync - Loading plugins from https://fastly.jsdelivr.net/gh/Flow-Launcher/Flow.Launcher.PluginsManifest@plugin_api_v2/plugins.json
16:22:39.6192+02:00 - INFO  - CommunityPluginSource.FetchAsync - Loading plugins from https://gcore.jsdelivr.net/gh/Flow-Launcher/Flow.Launcher.PluginsManifest@plugin_api_v2/plugins.json
16:22:39.6192+02:00 - INFO  - CommunityPluginSource.FetchAsync - Loading plugins from https://cdn.jsdelivr.net/gh/Flow-Launcher/Flow.Launcher.PluginsManifest@plugin_api_v2/plugins.json
16:22:39.6192+02:00 - INFO  - CommunityPluginSource.FetchAsync - Loading plugins from https://raw.githubusercontent.com/Flow-Launcher/Flow.Launcher.PluginsManifest/plugin_api_v2/plugins.json
16:22:39.7242+02:00 - INFO  - CommunityPluginSource.FetchAsync - Resource https://cdn.jsdelivr.net/gh/Flow-Launcher/Flow.Launcher.PluginsManifest@plugin_api_v2/plugins.json has not been modified.
16:22:50.0378+02:00 - INFO  - App.OnStartup - Begin Flow Launcher startup ----------------------------------------------------
16:22:50.0538+02:00 - INFO  - App.OnStartup - Runtime info:
Flow Launcher version: 1.18.0
OS Version: 22631.3447
IntPtr Length: 8
x64: True
16:22:50.1756+02:00 - ERROR - PluginConfig.GetPluginMetadata - invalid json for config <C:\Users\Laurin\AppData\Local\FlowLauncher\app-1.18.0\UserData\Plugins\FileZilla-1.0.0\plugin.json>
EXCEPTION OCCURS: System.ArgumentNullException: Value cannot be null. (Parameter 'path2')
   at void ArgumentNullException.Throw(string paramName)
   at string System.IO.Path.Combine(string path1, string path2)
   at void Flow.Launcher.Plugin.PluginMetadata.set_PluginDirectory(string value) in /_/Flow.Launcher.Plugin/PluginMetadata.cs:line 28
   at PluginMetadata Flow.Launcher.Core.Plugin.PluginConfig.GetPluginMetadata(string pluginDirectory) in C:/projects/flow-launcher/Flow.Launcher.Core/Plugin/PluginConfig.cs:line 113

16:22:50.2423+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Plugin Indicator> is <1ms>
16:22:50.2423+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Process Killer> is <1ms>
16:22:50.2423+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <System Commands> is <1ms>
16:22:50.2423+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <URL> is <11ms>
16:22:50.2423+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Flow.Plugin.UrlEncode> is <0ms>
16:22:50.2583+02:00 - INFO  - CommunityPluginSource.FetchAsync - Loading plugins from https://fastly.jsdelivr.net/gh/Flow-Launcher/Flow.Launcher.PluginsManifest@plugin_api_v2/plugins.json
16:22:50.2583+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Web Searches> is <21ms>
16:22:50.2583+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Shell> is <25ms>
16:22:50.2583+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <RollDice> is <25ms>
16:22:50.2583+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Calculator> is <31ms>
16:22:50.2583+02:00 - INFO  - Flow.Launcher.Plugin.Program.Main - Preload programs cost <11ms>
16:22:50.2583+02:00 - INFO  - Flow.Launcher.Plugin.Program.Main - Number of preload win32 programs <911>
16:22:50.2583+02:00 - INFO  - Flow.Launcher.Plugin.Program.Main - Number of preload uwps <30>
16:22:50.2785+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Windows Settings> is <35ms>
16:22:50.2785+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <VS Code Workspaces> is <39ms>
16:22:50.2785+02:00 - INFO  - CommunityPluginSource.FetchAsync - Loading plugins from https://gcore.jsdelivr.net/gh/Flow-Launcher/Flow.Launcher.PluginsManifest@plugin_api_v2/plugins.json
16:22:50.2877+02:00 - INFO  - CommunityPluginSource.FetchAsync - Loading plugins from https://cdn.jsdelivr.net/gh/Flow-Launcher/Flow.Launcher.PluginsManifest@plugin_api_v2/plugins.json
16:22:50.2877+02:00 - INFO  - CommunityPluginSource.FetchAsync - Loading plugins from https://raw.githubusercontent.com/Flow-Launcher/Flow.Launcher.PluginsManifest/plugin_api_v2/plugins.json
16:22:50.2877+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Program> is <61ms>
16:22:50.2877+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Explorer> is <66ms>
16:22:50.3094+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Currency Converter> is <66ms>
16:22:50.3094+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Browser Bookmarks> is <75ms>
16:22:50.4496+02:00 - INFO  - CommunityPluginSource.FetchAsync - Loaded 159 plugins from https://cdn.jsdelivr.net/gh/Flow-Launcher/Flow.Launcher.PluginsManifest@plugin_api_v2/plugins.json
16:22:50.4496+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Plugins Manager> is <212ms>
16:22:50.5791+02:00 - INFO  - App.OnStartup - Dependencies Info:
Python Path: C:\Program Files\Python312\pythonw.exe
Node Path: C:\Program Files\nodejs\node.exe
16:22:50.8167+02:00 - INFO  - App.OnStartup - End Flow Launcher startup ----------------------------------------------------  
16:22:50.8167+02:00 - INFO  - App.OnStartup - Startup cost <823ms>
16:22:52.2241+02:00 - INFO  - Updater.UpdateApp - Future Release <{
  "SHA1": "0F4C15147CCE5AD43CBE27120B61230BB834A32E",
  "BaseUrl": null,
  "Filename": "FlowLauncher-1.18.0-full.nupkg",
  "Query": null,
  "Filesize": 105458488,
  "IsDelta": false,
  "StagingPercentage": null,
  "EntryAsString": "0F4C15147CCE5AD43CBE27120B61230BB834A32E FlowLauncher-1.18.0-full.nupkg 105458488",
  "Version": {
    "Version": "1.18.0.0",
    "SpecialVersion": ""
  },
  "PackageName": "FlowLauncher"
}>
16:22:52.5998+02:00 - INFO  - ImageLoader.Initialize - Preload images cost <2309ms>
16:22:52.5998+02:00 - INFO  - ImageLoader.Initialize - Number of preload images is <129>, Images Number: 129, Unique Items 90

Both python and node installations are valid. Here is the zipped plugin folder, i think there are identical, but i rather give you more info then not enough: FileZilla-1.0.0.zip

Hope this helps.

Edit: And of cause I have FileZilla installed in C:\Program Files\FileZilla FTP Client\filezilla.exe

shaffe-fr commented 6 months ago

Hi, sorry to ear about this issue. I'll check it asap.

shaffe-fr commented 6 months ago

Hi, I released a new 1.0.2 version that should fix the issue. It's not yet showing inside the plugin Store.

Myxoz commented 6 months ago

For both i cleared the logs, copied the exctracted zip folder in and then restarted flow launcher from "Restart Flow Launcher"

So for 1.0.1 its:

18:09:49.7139+02:00 - INFO  - App.OnStartup - Begin Flow Launcher startup ----------------------------------------------------
18:09:49.7139+02:00 - INFO  - App.OnStartup - Runtime info:
Flow Launcher version: 1.18.0
OS Version: 22631.3593
IntPtr Length: 8
x64: True
18:09:49.8248+02:00 - ERROR - PluginConfig.GetPluginMetadata - execute file path didn't exist <C:\Users\Laurin\AppData\Local\FlowLauncher\app-1.18.0\UserData\Plugins\Flow.Launcher.Plugin.FileZilla\./dist/main.ts> for conifg <C:\Users\Laurin\AppData\Local\FlowLauncher\app-1.18.0\UserData\Plugins\Flow.Launcher.Plugin.FileZilla\plugin.json
18:09:49.8920+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <URL> is <11ms>
18:09:49.8920+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Process Killer> is <1ms>
18:09:49.8920+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <System Commands> is <1ms>
18:09:49.8920+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Plugin Indicator> is <1ms>
18:09:49.8920+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Flow.Plugin.UrlEncode> is <0ms>
18:09:49.9087+02:00 - INFO  - CommunityPluginSource.FetchAsync - Loading plugins from https://fastly.jsdelivr.net/gh/Flow-Launcher/Flow.Launcher.PluginsManifest@plugin_api_v2/plugins.json
18:09:49.9106+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Web Searches> is <22ms>
18:09:49.9106+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Shell> is <24ms>
18:09:49.9106+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Calculator> is <29ms>
18:09:49.9106+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Number Converter> is <11ms>
18:09:49.9106+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <RollDice> is <9ms>
18:09:49.9106+02:00 - INFO  - Flow.Launcher.Plugin.Program.Main - Preload programs cost <11ms>
18:09:49.9106+02:00 - INFO  - Flow.Launcher.Plugin.Program.Main - Number of preload win32 programs <148>
18:09:49.9106+02:00 - INFO  - Flow.Launcher.Plugin.Program.Main - Number of preload uwps <30>
18:09:49.9287+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Windows Settings> is <37ms>
18:09:49.9287+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <VS Code Workspaces> is <41ms>
18:09:49.9287+02:00 - INFO  - CommunityPluginSource.FetchAsync - Loading plugins from https://gcore.jsdelivr.net/gh/Flow-Launcher/Flow.Launcher.PluginsManifest@plugin_api_v2/plugins.json
18:09:49.9400+02:00 - INFO  - CommunityPluginSource.FetchAsync - Loading plugins from https://cdn.jsdelivr.net/gh/Flow-Launcher/Flow.Launcher.PluginsManifest@plugin_api_v2/plugins.json
18:09:49.9400+02:00 - INFO  - CommunityPluginSource.FetchAsync - Loading plugins from https://raw.githubusercontent.com/Flow-Launcher/Flow.Launcher.PluginsManifest/plugin_api_v2/plugins.json
18:09:49.9400+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Program> is <61ms>
18:09:49.9400+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Explorer> is <65ms>
18:09:49.9610+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Currency Converter> is <68ms>
18:09:49.9610+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <General Converter> is <68ms>
18:09:49.9610+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Search MDN> is <39ms>
18:09:49.9610+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Browser Bookmarks> is <75ms>
18:09:50.1863+02:00 - INFO  - CommunityPluginSource.FetchAsync - Loaded 160 plugins from https://fastly.jsdelivr.net/gh/Flow-Launcher/Flow.Launcher.PluginsManifest@plugin_api_v2/plugins.json
18:09:50.1863+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Plugins Manager> is <299ms>
18:09:50.3295+02:00 - INFO  - App.OnStartup - Dependencies Info:
Python Path: C:\Program Files\Python312\pythonw.exe
Node Path: C:\Program Files\nodejs\node.exe
18:09:50.5548+02:00 - INFO  - App.OnStartup - End Flow Launcher startup ----------------------------------------------------  
18:09:50.5548+02:00 - INFO  - App.OnStartup - Startup cost <901ms>
18:09:51.9338+02:00 - INFO  - Updater.UpdateApp - Future Release <{
  "SHA1": "0F4C15147CCE5AD43CBE27120B61230BB834A32E",
  "BaseUrl": null,
  "Filename": "FlowLauncher-1.18.0-full.nupkg",
  "Query": null,
  "Filesize": 105458488,
  "IsDelta": false,
  "StagingPercentage": null,
  "EntryAsString": "0F4C15147CCE5AD43CBE27120B61230BB834A32E FlowLauncher-1.18.0-full.nupkg 105458488",
  "Version": {
    "Version": "1.18.0.0",
    "SpecialVersion": ""
  },
  "PackageName": "FlowLauncher"
}>
18:09:52.0000+02:00 - INFO  - ImageLoader.Initialize - Preload images cost <2048ms>
18:09:52.0000+02:00 - INFO  - ImageLoader.Initialize - Number of preload images is <150>, Images Number: 150, Unique Items 86

And for 1.0.2 its:

18:13:17.7113+02:00 - INFO  - App.OnStartup - Begin Flow Launcher startup ----------------------------------------------------
18:13:17.7113+02:00 - INFO  - App.OnStartup - Runtime info:
Flow Launcher version: 1.18.0
OS Version: 22631.3593
IntPtr Length: 8
x64: True
18:13:17.8250+02:00 - ERROR - PluginConfig.GetPluginMetadata - execute file path didn't exist <C:\Users\Laurin\AppData\Local\FlowLauncher\app-1.18.0\UserData\Plugins\Flow.Launcher.Plugin.FileZilla\./dist/index.js> for conifg <C:\Users\Laurin\AppData\Local\FlowLauncher\app-1.18.0\UserData\Plugins\Flow.Launcher.Plugin.FileZilla\plugin.json
18:13:17.8916+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <URL> is <11ms>
18:13:17.8916+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Process Killer> is <1ms>
18:13:17.8916+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Plugin Indicator> is <1ms>
18:13:17.8916+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <System Commands> is <1ms>
18:13:17.8916+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Flow.Plugin.UrlEncode> is <0ms>
18:13:17.9088+02:00 - INFO  - CommunityPluginSource.FetchAsync - Loading plugins from https://fastly.jsdelivr.net/gh/Flow-Launcher/Flow.Launcher.PluginsManifest@plugin_api_v2/plugins.json
18:13:17.9088+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Web Searches> is <22ms>
18:13:17.9088+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Shell> is <25ms>
18:13:17.9088+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Calculator> is <31ms>
18:13:17.9088+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Number Converter> is <11ms>
18:13:17.9088+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <RollDice> is <9ms>
18:13:17.9088+02:00 - INFO  - Flow.Launcher.Plugin.Program.Main - Preload programs cost <11ms>
18:13:17.9088+02:00 - INFO  - Flow.Launcher.Plugin.Program.Main - Number of preload win32 programs <148>
18:13:17.9088+02:00 - INFO  - Flow.Launcher.Plugin.Program.Main - Number of preload uwps <30>
18:13:17.9272+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Windows Settings> is <35ms>
18:13:17.9272+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <VS Code Workspaces> is <39ms>
18:13:17.9272+02:00 - INFO  - CommunityPluginSource.FetchAsync - Loading plugins from https://gcore.jsdelivr.net/gh/Flow-Launcher/Flow.Launcher.PluginsManifest@plugin_api_v2/plugins.json
18:13:17.9272+02:00 - INFO  - CommunityPluginSource.FetchAsync - Loading plugins from https://cdn.jsdelivr.net/gh/Flow-Launcher/Flow.Launcher.PluginsManifest@plugin_api_v2/plugins.json
18:13:17.9272+02:00 - INFO  - CommunityPluginSource.FetchAsync - Loading plugins from https://raw.githubusercontent.com/Flow-Launcher/Flow.Launcher.PluginsManifest/plugin_api_v2/plugins.json
18:13:17.9465+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Program> is <60ms>
18:13:17.9465+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Explorer> is <62ms>
18:13:17.9592+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Currency Converter> is <67ms>
18:13:17.9592+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <General Converter> is <67ms>
18:13:17.9592+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Search MDN> is <39ms>
18:13:17.9592+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Browser Bookmarks> is <73ms>
18:13:18.2700+02:00 - INFO  - CommunityPluginSource.FetchAsync - Loaded 160 plugins from https://raw.githubusercontent.com/Flow-Launcher/Flow.Launcher.PluginsManifest/plugin_api_v2/plugins.json
18:13:18.2700+02:00 - INFO  - PluginManager.InitializePlugins - Total init cost for <Plugins Manager> is <384ms>
18:13:18.4113+02:00 - INFO  - App.OnStartup - Dependencies Info:
Python Path: C:\Program Files\Python312\pythonw.exe
Node Path: C:\Program Files\nodejs\node.exe
18:13:18.6594+02:00 - INFO  - App.OnStartup - End Flow Launcher startup ----------------------------------------------------  
18:13:18.6605+02:00 - INFO  - App.OnStartup - Startup cost <1008ms>
18:13:20.1125+02:00 - INFO  - Updater.UpdateApp - Future Release <{
  "SHA1": "0F4C15147CCE5AD43CBE27120B61230BB834A32E",
  "BaseUrl": null,
  "Filename": "FlowLauncher-1.18.0-full.nupkg",
  "Query": null,
  "Filesize": 105458488,
  "IsDelta": false,
  "StagingPercentage": null,
  "EntryAsString": "0F4C15147CCE5AD43CBE27120B61230BB834A32E FlowLauncher-1.18.0-full.nupkg 105458488",
  "Version": {
    "Version": "1.18.0.0",
    "SpecialVersion": ""
  },
  "PackageName": "FlowLauncher"
}>
18:13:20.2663+02:00 - INFO  - ImageLoader.Initialize - Preload images cost <2310ms>
18:13:20.2683+02:00 - INFO  - ImageLoader.Initialize - Number of preload images is <149>, Images Number: 149, Unique Items 86
shaffe-fr commented 6 months ago

Let's see how it goes with 1.0.2...

Myxoz commented 6 months ago

I tried both of them, they both dont work. I includes both logs above Maybe its something with the paths, which you changed in both releases cause it says bla\bla\something\./dist/main.js isnt a valid path. I dont know, but it seams logical

Edit: To be exact its: <C:\Users\Laurin\AppData\Local\FlowLauncher\app-1.18.0\UserData\Plugins\Flow.Launcher.Plugin.FileZilla\./dist/index.js>

(For Version 1.0.2)

shaffe-fr commented 6 months ago

Yeah, correct, the path was not good.... 1.0.3 should be good 😅

Myxoz commented 6 months ago

Trying it today, you'll hear from me later...

shaffe-fr commented 6 months ago

You can try again. It's working! Thanks for your help!