shafreeck / cetcd

Cetcd is a C client library for etcd with full features support
Apache License 2.0
69 stars 39 forks source link

Don't export SDS API and don't install sds header file. #44

Closed thkukuk closed 7 years ago

thkukuk commented 7 years ago

SDS is used by cetcd only internal, not by the public API. We should not expose the SDS API, else other projects using SDS could get a problem.

shafreeck commented 7 years ago

Gook point! Thanks a lot!

shafreeck commented 7 years ago

I reverted this pull request. SDS should be exported to support pass an binary safe string to cetcd functions (cetcd_set ...)