search

shagu / pfQuest

A Questhelper and Database Addon for World of Warcraft: Vanilla & TBC
https://shagu.org/pfQuest
MIT License
192 stars 52 forks source link

low FPS issue (TBC) #111

Closed GioBego closed 4 years ago

GioBego commented 4 years ago

game has extremely low FPS while there is too many points on the map (TBC client)

shagu commented 4 years ago

Do you have any addon running which collects addon-buttons on the minimap?

GioBego commented 4 years ago

yes, should this be relevant? ... when I disable tracking of quest with many points, FPS goes back to normal ... so it is only affected by amount of points in map it seems

shagu commented 4 years ago

Depending on which addon you use. Most of the addon button gather addons are not aware of pfQuest as it didn't exist when they were made. Therefore, some of them pick up the nodes of pfQuest and some of them can't handle that many objects on the minimap.

GioBego commented 4 years ago

Elv UI (version updated for TBC) and some included plugin for sorting the minimap buttons

GioBego commented 4 years ago

will removing button from minimap help ? will test it when FPS drops again

shagu commented 4 years ago

It's not about the minimap icon. It's about the nodes on the minimap. At least that's something others reported. Each Minimap-Addon-Button addon includes a list of Frames that should be ignored (Gatherer and such). One would need to add pfQuest's icon names to the list aswell. But since those 2007' made addons are out of support, nobody is willing to take over the responsibility for them. Regarding ElvUI, I don't know how much activity there is nowadays on the backport.

GioBego commented 4 years ago

I will test if turning off minimap nodes helps. Thanks for your help.

p.s.: I would gladly use pfUI for TBC if it was compatible with Clique ... that is only reason I had to switch to ElvUI ... built in solution was not sufficient alternative to Clique

shagu commented 4 years ago

Add "pfMiniMapPin" to https://github.com/ElvUI-TBC/ElvUI_MinimapButtons/blob/master/ElvUI_MinimapButtons/ElvUI_MinimapButtons.lua#L247 to make it ignore the pfQuest icons.

p.s.: I would gladly use pfUI for TBC if it was compatible with Clique ... that is only reason I had to switch to ElvUI ... built in solution was not sufficient alternative to Clique

What was missing?

GioBego commented 4 years ago

What was missing?

ease of use(settings in spellbook with all options Clique has) , save separate settings for alts while using one profile for UI ... and support for alternative addons like Grid for example ... Clique is simply the standard everybody is used to ... I loved your ui had compatible Clique version for Vanilla

shagu commented 4 years ago

I will test if turning off minimap nodes helps. Thanks for your help.

Try the latest version (5.2.6). The pfQuest minimap-nodes now mimic the names of Gatherer while a button collector is active, in order to not get grabbed by their algorithm. (https://github.com/shagu/pfQuest/commit/31ed59ee770d8bf3f0708a1a5598e2fc4da9b21c)

shagu commented 4 years ago

p.s.: I would gladly use pfUI for TBC if it was compatible with Clique

There you go: https://github.com/shagu/pfUI/commit/fa966b99305f8172b76bfa151dfa8648922bfa2e, pfUI has clique (tbc) support now.