search

shagu / pfUI

A User Interface Replacement for World of Warcraft: Vanilla & TBC
https://shagu.org/pfUI
MIT License
341 stars 116 forks source link

Skin Harcore Death & Super Macros button. Extending the game menu to fit. #1166

Closed 8EightySixed6 closed 1 year ago

8EightySixed6 commented 1 year ago

Allowed pfUI to skin Hardcore Death Log and Super Macros.

Extending the main menu allowing the extra button.

image

shagu commented 1 year ago

Hi, thanks for the PR :)

What made you decide to always increase the size of the Game Menu? Doesn't it work to only increase it if Hardcore Death Log is loaded?

Merging it like that, would make it looks weird for everyone who doesn't use Hardcore Death Log.

8EightySixed6 commented 1 year ago

@shagu

I had "MoveAnything!" and "Hardcore Death Log" overlap each other. I couldn't figure out how to get Hardcore Death Log in the menu without overlapping another button. I could move it up and down but it always overlapped. I needed "MoveAnything!" enabled because I have a 49" wide screen monitor and always looking left for quest log or Spell book got to be a pain.

So I started looking at the code for pfUI and after about an hour of looking for the right doc I found where you hooked the skins for apps. So I skinned the button for Hard Core Death log and Super Macros.

Once I skinned the buttons I went back trying to figure out how to make it all fit. I couldn't figure out how to get it in the main menu without overlapping so I just moved the button down to its own spot.

8EightySixed6 commented 1 year ago

I do agree with the merge though, it would look kind of funny LOL but the skins would be cool to add in there.

shagu commented 1 year ago

I changed it a bit and merged it here: https://github.com/shagu/pfUI/commit/80ac434fb4ae72e455fd0ec3fd7d89cefff37a1e

Thanks for your PR :)