search

shagu / pfUI

A User Interface Replacement for World of Warcraft: Vanilla & TBC
https://shagu.org/pfUI
MIT License
333 stars 116 forks source link

Fix channeling #1277

Closed pepopo978 closed 2 months ago

pepopo978 commented 2 months ago

noticed it wasn't detecting channeled spells, copied Balake's logic but maybe should also ignore FAIL?

arg3: event type ("START", "CAST", "FAIL", "CHANNEL", "MAINHAND", "OFFHAND")
shagu commented 2 months ago

Have you tested it? Also where have you tested it?

shagu commented 2 months ago

Done: https://github.com/shagu/pfUI/commit/ae94b5d1502760b307a20fdaa4f200fff25c2dbd https://github.com/shagu/pfUI/commit/e95c02e98175adeaada7607e63f8d09bb5155833 https://github.com/shagu/pfUI/commit/cc5ad5d3d44fe243a5f2155249068f99bfa61e4a