search

shagu / pfUI

A User Interface Replacement for World of Warcraft: Vanilla & TBC
https://shagu.org/pfUI
MIT License
343 stars 116 forks source link

libspell: Searching GetSpellIndex("Holy Light", "Rank 3") and then searching for GetSpellIndex("Holy Light(Rank 3)") should result in a cache-hit the second time around but it doesn't #1302

Closed dsidirop closed 3 months ago

dsidirop commented 4 months ago

The culprit lies in the way we store/seek spells in the cache. We are currently storing:

spellindex[name..(rank or "")]

But we should be storing:

spellindex[name..(rank and ("("..rank..")") or "")]