search

shagu / pfUI

A User Interface Replacement for World of Warcraft: Vanilla & TBC
https://shagu.org/pfUI
MIT License
341 stars 116 forks source link

Bug with MasterLooter feature in pfui #1313

Closed welpenhund closed 5 days ago

welpenhund commented 1 month ago

We experienced a rare case in our Raid yesterday That bug might have been caused by either client lag, server lag and/or a failure in the addon. I would like to bring this up cause it might happen again in future and might be fixable?

Master loot set Epic Item Dropped on Trash, with 2 trash drops ahead of it.

Master Looter tried to raid roll out FIRST trash item - didnt register

Master Looter tried to raid roll out FIRST trash item again - didnt register

Master Looter tried to raid roll out FIRST trash item one more time - it random rolled out BOTH trash drops and the epic on it now after the third time instead of only rolling out the selected trash items.

grafik

shagu commented 1 month ago

Interesting. Sounds more like a lag to me. I don't get the "didn't register". You describe he clicked it 3 times, and it rolled 3 items, so it did register, no? You have just been lagging.

Anyhow, That feature has been a contribution of someone else and it's there for already so long, I didn't even remember merging it anymore. If you really hit the bug for the first time in the past 7 years, and someone wants to fix it please send a pull request. As I personally never used it and also don't plan to, I would rather remove it from pfUI than fixing it. Let's leave the ticket open for the next 30 days in case someone wants to work on it.

welpenhund commented 1 month ago

Interesting. Sounds more like a lag to me. I don't get the "didn't register". You describe he clicked it 3 times, and it rolled 3 items, so it did register, no? You have just been lagging.

Anyhow, That feature has been a contribution of someone else and it's there for already so long, I didn't even remember merging it anymore. If you really hit the bug for the first time in the past 7 years, and someone wants to fix it please send a pull request. As I personally never used it and also don't plan to, I would rather remove it from pfUI than fixing it. Let's leave the ticket open for the next 30 days in case someone wants to work on it.

No it seems to be happening if someone is out of range after this is clicked. The more people are not in range for it the higher the chance seems to be to occur. (i wont mind if it gets removed, i just thought i should report it since it is a neat feature but nothing mendotary that is a must have)

shagu commented 1 month ago

i just thought i should report it since it is a neat feature

Ofc, Thanks for reporting :) I'm just wondering why nobody did in the past 7 years.

Could you please provide a clear step by step instruction how to reproduce it? In case somebody wants to work on it.

welpenhund commented 1 month ago

i just thought i should report it since it is a neat feature

Ofc, Thanks for reporting :) I'm just wondering why nobody did in the past 7 years.

Could you please provide a clear step by step instruction how to reproduce it? In case somebody wants to work on it.

Quote by the one who did Master Loot: """pressed "Give loot to: Random" in PFui menu on gray item, nothing happened. (repeat process x3) 5 seconds later all these rolls catch up and every item on the mob is rolled out."""

github-actions[bot] commented 2 weeks ago

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] commented 5 days ago

This issue was closed because it has been inactive for 14 days since being marked as stale.