shagu / pfUI

A User Interface Replacement for World of Warcraft: Vanilla & TBC
https://shagu.org/pfUI
MIT License
348 stars 117 forks source link

"Enable Durations on Foreign Frames" not working on Luna Unit Frames Target Debuffs unless DebuffTimers is enabled? #1321

Closed zmarotrix closed 1 month ago

zmarotrix commented 2 months ago

I'm using Luna Unit Frames and pfUI shown below.

image image

Here are my cooldown settings in pfUI image

Cooldowns seem to be working on both the action bars (pfUI) and the Luna Unit Frame Buffs, but not the Luna Unit Frames Debuffs.

image

This was frustrating but not a huge deal because I just enabled DebuffTimers.

image

But when I enabled Debuff Timers, Suddenly the pfUI timers are working beneath the DebuffTimers??

image

image

I know DebuffTimers specifically singles out Luna Unit Frames but I don't understand how that would effect pfUI's ability to see the debuffs? I cannot set DebuffTimers size to 0 or my chat gets flooded with error messages. Is there something I'm missing? Some fix for this situation?

zmarotrix commented 2 months ago

Tested with only combinations of these 3 addons enabled and no other addons.

shagu commented 2 months ago

The cooldown setting in pfUI adds text to cooldown animations (the circular animation). It's like OmniCC, only what has a timer, will get a text field. The pfUI actionsbars, and pfUI unitframes have those animations, so it also adds numbers there.

Luna Unit Frames however doesn't have any debuff duration informations, so there's no cooldown frame that could be picked up by pfUI. For that, you need to enable another addon like DebuffTimers to explicitly extend Luna Unit Frames with debuff durations. That moment, those debuffs get an animation and pfUI can pick it up if "Enable on Foreign Frames" is enabled. But DebuffTimers also adds numbers to the cooldown animations, leaving you then with two text-fields on the animation.

I suggest to disable "Enable on Foreign Frames", so that pfUI does NOT put its timer ontop of the timer added by DebuffTimers.

zmarotrix commented 2 months ago

Oh I understand, that actually cleared up the confusion. I managed to just modify DebuffTimers to remove the text and that seems to have fixed the issue. I'm sure there's probably a more elegant way to do this but I'll look into that later.

I'd prefer to have uniform timers across the board than use 2 different timers.