#issue 25 Resolved Page breaking down at bottom

pranjalagrawal2012 commented 3 years ago

Related Issue

Back Arrow in each page was not working properly

Breaking body page on bottom

Closes: #[issue number that will be closed through this PR]

issue-23

issue-25

Describe the changes you've made

Went through various upgradation of packages and flutter updating, Check every page for the back arrow issue

Type of change

What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Mention any unusual behaviour of your code (Write NA if not)

Any unusual behaviour of your code

Checklist:

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly whereever it was hard to understand.
[ ] My changes generate no new warnings.
[ ] Any dependent changes have been merged and published in downstream modules.

Additional Info (optional)

Any additional information you want to give

hiashutoshsingh commented 3 years ago

WhatsApp Image 2021-03-16 at 10 48 59 AM (1)

@pranjalagrawal2012 UI is breaking on some phone. I tested this on a 5.5-inch android phone. What you can do here to make it responsive on all phones. This is a very easy-peasy task.

Let me know if you need some help with this.

hiashutoshsingh commented 3 years ago

It's not recommended to send a lock file(e.g pubspec.lock) from another environment. It should remain intact with one user only. @pranjalagrawal2012

pranjalagrawal2012 commented 3 years ago

Made the Changes and resolved the issue of screen overflowing @hiashutoshsingh @shagun25

hiashutoshsingh commented 3 years ago

@pranjalagrawal2012 Hey, you look into these conflicts. I hope you are behind master. Please do this carefully this may break something.

hiashutoshsingh commented 3 years ago

Hey, @pranjalagrawal2012 didn't get an update from your side. Is there any issue are facing to making changes. Let me know.

hiashutoshsingh commented 3 years ago

Hey, closing this PR because it is awaiting for a long time. Feel free to open again with new changes.

Thanks.

shagun25 / SheHeroes