shagun25 / SheHeroes

SheHeroes- A Women And Child Safety App
https://discord.com/channels/811724426965811210/815018090991321099
Creative Commons Zero v1.0 Universal
76 stars 92 forks source link

Record Video In Background Added with Quick Actions #84

Closed SamarpanCoder2002 closed 3 years ago

SamarpanCoder2002 commented 3 years ago

Issue: #54

Closes: #54

Describe the changes you've made

Added Record Video Option with quick actions to immediate capture video.....

Make Sure you should not try it in your emulator....That may be raise a problem or app crash.... To test this feature.... Use physical device to connect with your IDE or make the apk file and install it in your phone and try it....

Trying in emulator may crash the app....as emulator has no camera..

Type of change

What sort of change have you made:

Mention any unusual behaviour of your code (Write NA if not)

Trying on Emulator, may causes problem during testing this feature....According to the mentioned above, try it with physical device....

Checklist:

Additional Info (optional)

Any additional information you want to give

Feature Video Demo: https://drive.google.com/file/d/1fggHAU6XJwB4IAwiLNQK5xZsT8BGTyqZ/view?usp=sharing

Hello @shagun25 @hiashutoshsingh , Please review this pull request and merge it

I am also a GSSOC21 participant...please raise the required labels(Related to that issue) for this program..

Thank u @shagun25 @hiashutoshsingh

SamarpanCoder2002 commented 3 years ago

@hiashutoshsingh I don't know why you cancel the level3 and add level2....You did the same in related issue...I think that's not fair...because I spend more than 2 days, to know about quick actions...and then implement it properly...

I request you to raise the level3 and remove the level2.... Because, it takes a lot of time to implement this...

Also I reply of your question...please take a look

Thanks @shagun25 @hiashutoshsingh

hiashutoshsingh commented 3 years ago

@hiashutoshsingh I don't know why you cancel the level3 and add level2....You did the same in related issue...I think that's not fair...because I spend more than 2 days, to know about quick actions...and then implement it properly...

I request you to raise the level3 and remove the level2.... Because, it takes a lot of time to implement this...

Also I reply of your question...please take a look

Thanks @shagun25 @hiashutoshsingh

Hey, I did it because of its complexity not because of time.

I saw that you have already implemented the background image https://github.com/shagun25/SheHeroes/pull/73/ part already with yourself without any help and it has around 40% same code logic, so I thought it's not fair to other participants to give a level3 tag on this issue.

If you still have confusion, let's connect on discord for the same.

SamarpanCoder2002 commented 3 years ago

Thanks for the contribution.

Thanks for merge it