This issue seems to be important when visualizing data. It would make the most sense to add scale extensions in the ggproto fashion to allow theme modifications and color modifications to occur.
Will have to make decisions on how to handle colour scales, such as material design colors on a light or dark background.
theme_egm_dark() makes sense to clean the plot and darken the background, but it shouldn't necessarily force the colors to change? Could force all white or all black by modifying scale colour here, but that seems worng.
scale_colour_channels_* may be an alternative scale that can allow for this, with options like...
scale_colour_channels_bw() like lspro
scale_colour_channels_wb() like pruka
[x] Evaluate how to extend ggplot2 for scales
[ ] Update theme functions to avoid changing color of scales
[ ] For base ggm() object, it should re-write the color choice to be dark or light based on if there is a "white" or "black" color for a channel that is pre-existing as the default
This issue seems to be important when visualizing data. It would make the most sense to add scale extensions in the
ggprotofashion to allow theme modifications and color modifications to occur.Will have to make decisions on how to handle colour scales, such as material design colors on a light or dark background.
theme_egm_dark()makes sense to clean the plot and darken the background, but it shouldn't necessarily force the colors to change? Could force all white or all black by modifying scale colour here, but that seems worng.scale_colour_channels_*may be an alternative scale that can allow for this, with options like...scale_colour_channels_bw() like lspro
scale_colour_channels_wb() like pruka
[x] Evaluate how to extend ggplot2 for scales
[ ] Update theme functions to avoid changing color of scales
[ ] For base
ggm()object, it should re-write the color choice to be dark or light based on if there is a "white" or "black" color for a channel that is pre-existing as the default