search

shahen94 / react-native-switch

Customisable switch component for RN
MIT License
296 stars 172 forks source link

Fix for warning about useNativeDriver #81

Closed SteveGreenley closed 4 years ago

SteveGreenley commented 4 years ago

With RN0.62.2, I was getting a warning about needing to specify a value for useNativeDriver. This change eliminates that warning.

Zontex commented 4 years ago

@shahen94 Please merge this to master

shahen94 commented 4 years ago

hey @SteveGreenley .

Thank you for your contribution. Can you please please mention why we should use false as a value instead of true ?

ventsislavnikolov commented 4 years ago

Hi @shahen94 ,

With true on useNativeDriver it gives a error, so should be false. I'm attaching a screenshot with the error. Screenshot_1597260413

Can we please now this go on master and we have the update to remove the warning.

shahen94 commented 4 years ago

Thanks for the explanation! Merging

jspizziri commented 4 years ago

@shahen94, could you please release the NPM package? None of us are able to access this goodness until that happens.

https://github.com/shahen94/react-native-switch/issues/83

jspizziri commented 3 years ago

In the interest of not waiting, republished this package under our org: @5stones/react-native-switch

Adding here in case anyone is looking for a patch for now. Please note, this is only intended to be used until this issue is fixed.