search

shahen94 / react-native-video-processing

Native Video editing/trimming/compressing :movie_camera: library for React-Native
https://shahen94.github.io/react-native-video-processing/
MIT License
1.25k stars 326 forks source link

Adding the possibility to trim a remote file #264

Closed santiagovazquez closed 4 years ago

santiagovazquez commented 4 years ago

I made some changes on trim function to be able to trim remote files.

Code based on: https://stackoverflow.com/questions/31383655/avassetexportsession-trim-download

santiagovazquez commented 4 years ago

@shahen94 any problem with this PR ?

shahen94 commented 4 years ago

We'll need also Android version of the feature.

BTW: Thanks for the PR!

santiagovazquez commented 4 years ago

Thanks for the responde @shahen94 ! When I first use this library I thought this feature would work because you could pass a URL as source. Since it didn't work on iOS, I made it work. I don't really know if this is working or not on Android (I think it should!). I will test and let you know

shahen94 commented 4 years ago

@santiagovazquez I guess, it shouldn't work, but anyway I'll merge this. Can you please just update readme and make a note about this?

Thanks!

santiagovazquez commented 4 years ago

@shahen94 done!

xlogix commented 4 years ago

The build is failing 😕Is this gonna be merged anytime soon?