search

shahen94 / react-native-video-processing

Native Video editing/trimming/compressing :movie_camera: library for React-Native
https://shahen94.github.io/react-native-video-processing/
MIT License
1.25k stars 326 forks source link

Portrait Videos showing landscape when loaded (only some) #275

Closed nica0012 closed 4 years ago

nica0012 commented 4 years ago

I've been playing with this library the past week and have had a lot of success. I was able to crop and trim my video after a lot of trial and error. I'm in a great spot but the one thing I can't seem to figure out is why only some portrait videos are being loaded as landscape.

I logged the dimensions with getVideoInfo and they seem to be correct. I have a case where I have two videos that are {"height": 1280, "width": 720} - one loads properly while the other is landscape... It is hard to debug, any idea what could be going wrong here?

nica0012 commented 4 years ago

After messing around a bit more, I found that compressing the videos that were showing landscape with the width and height captured from getVideoInfo gives me the proper orientation.

This is nice but I don't know if compressing directly after a user selects the video is a good idea due to loss of quality and delay?

@shahen94 Do you have anything in mind regarding this? I would love to hear your thoughts.

nica0012 commented 4 years ago

Would love to hear back still @shahen94 but I think my solution is good enough, pretty quick on a release build and they're going to have to compress prior to uploading either way.