search

shahinrostami / plotapi

Engaging visualisations, made easy.
https://plotapi.com
MIT License
268 stars 17 forks source link

Credit flag no longer working #38

Closed zedrdave closed 3 years ago

zedrdave commented 3 years ago

It seems there was a regression introduced: passing credit=False to Chord pro no longer produces a version without credit (it has less text than the credit=True version, but still some)… From looking at the client code: the problem is on the server side…

(sorry to bother you again! Hopefully this is an easy one to fix 😅)

zedrdave commented 3 years ago

I think you are in the middle of tinkering with this, so just on the off-chance that can help, I think you got the wrong commenting style for the injected JS: 😉

Screenshot 2021-04-11 at 18 45 09
shahinrostami commented 3 years ago

I think you are in the middle of tinkering with this, so just on the off-chance that can help, I think you got the wrong commenting style for the injected JS: 😉

Screenshot 2021-04-11 at 18 45 09

You guessed correctly! I was in middle of testing it and then I had to answer the door... one moment!

zedrdave commented 3 years ago

No worries. I'm taking a break anyway… Just didn't want you to spend time wondering why code wasn't working… because of a silly commenting format error (I know how that goes) 😅

shahinrostami commented 3 years ago

No worries. I'm taking a break anyway… Just didn't want you to spend time wondering why code wasn't working… because of a silly commenting format error (I know how that goes) 😅

All done now 😃 if you're interested, that mistake was me forgetting single-line Mako comments were with "##"! Thank you for pointing it out