search

shahzeb1 / soundcloud-player

🎶 A proof of concept SoundCloud player which uses public API's to play music in the browser.
https://shahzeb1.github.io/soundcloud-player/
26 stars 13 forks source link

Fixes for Issue #4 #7

Closed PaulTFreedman closed 7 years ago

PaulTFreedman commented 7 years ago

I've attempted to implement the requested features here. Note that as part of my troubleshooting process I changed onto Bootstrap v4 - I think this was probably not necessary in the end but figured I might as well leave it on the newer version.

shahzeb1 commented 7 years ago

Awesome job! 👍

Some feedback:

image I'm not too familiar with Bootstrap v4 and since it seems to be in alpha, I didn't commit to using it. As the image shows, there seems to be be a breakpoint where the grid seems to break. If you can fix this grid breaking issue, then I'll go ahead and merge it!

Great job overall!

shahzeb1 commented 7 years ago

What it currently looks like at that particular breakpoint:

image

PaulTFreedman commented 7 years ago

@shahzeb1 I've made those changes, how does it look now? I also changed the cursor used when you hover over the extra artwork and the buttons but can easily revert if you'd rather not have that.

shahzeb1 commented 7 years ago

Awesome! Merged.