Open shaigue opened 1 year ago
@zbambergerNLP Can you do a code review for the main enterence script I wrote (create_pmi_masking_vocab.py) ?
If you have any comments, edit the original file and add comments:
# TODO: bla bla bla ...
Once you are finished let me know, I'll go through your notes and if I have any questions we can set up a quick meeting to discuss.
It will give us a chance to experiment with this code review format:)
You can also go over the README.md and leave comments there if you have any. Let me know what you think about it and if it is readable.
***UPDATE 22.06.2023 waiting on that
***UPDATE 03.07.2023 working on that, TODO's in the code + readme.
@zbambergerNLP Can you do a code review for the main enterence script I wrote (create_pmi_masking_vocab.py) ?
If you have any comments, edit the original file and add comments:
# TODO: bla bla bla ...
Once you are finished let me know, I'll go through your notes and if I have any questions we can set up a quick meeting to discuss.
It will give us a chance to experiment with this code review format:)
You can also go over the README.md and leave comments there if you have any. Let me know what you think about it and if it is readable.
***UPDATE 22.06.2023 waiting on that
***UPDATE 03.07.2023 working on that, TODO's in the code + readme.