Allow linking zlib library

[GoogleCodeExporter]

open-vcdiff contains old copies of zlib's adler32.c, zlib.h and zconf.h. For a 
project that uses open-vcdiff and links to zlib library (e.g. Chromium), the 
duplicated code will cause unnecessary binary size increase, or conflicts 
during linking.

Original issue reported on code.google.com by wangxianzhu@chromium.org on 1 Mar 2012 at 10:15

[GoogleCodeExporter]

Placing zlib.h and zconf.h under src/ will also make the user include the wrong 
version of zlib header files if it uses open-vcdiff and zlib simultaneously.

I suggest to move zlib.h, zconf.h and adler32.c into another directory, so the 
user can easily exclude them from their build environment.

Original comment by wangxianzhu@chromium.org on 2 Mar 2012 at 12:19

[GoogleCodeExporter]

Proposed patch using the method in #1.

Original comment by wangxianzhu@chromium.org on 29 Mar 2012 at 4:46

Attachments:

• patch

[GoogleCodeExporter]

Actually I moved zlib, zconf.h and adler32.c into src/zlib, but my patch 
generated with 'svn diff' seems not to replay that.

FYI, the output of 'svn status':
M       Makefile.in
A       src/zlib
A  +    src/zlib/zconf.h
A  +    src/zlib/zlib.h
A  +    src/zlib/adler32.c
D       src/zconf.h
D       src/zlib.h
D       src/adler32.c
M       vsprojects/vcdcom/vcdcom.vcproj
M       Makefile.am

Original comment by wangxianzhu@chromium.org on 29 Mar 2012 at 5:15

[GoogleCodeExporter]

Patch included in version 0.8.3 of open-vcdiff.  Thanks much for reporting the 
issue and for providing a patch.

Original comment by openvcd...@gmail.com on 3 Apr 2012 at 6:15

• Changed state: Fixed