shairai / angleproject

Automatically exported from code.google.com/p/angleproject
Other
0 stars 0 forks source link

Implement missing variants of builtin functions min, max and clamp #914

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Implement missing variants of min, max and clamp functions

Missing variants that are introduced in GLES3:
min:
genIType min (genIType x, genIType y)
genIType min (genIType x, int y)
genUType min (genUType x, genUType y)
genUType min (genUType x, uint y)

max:
genIType max (genIType x, genIType y)
genIType max (genIType x, int y)
genUType max (genUType x, genUType y)
genUType max (genUType x, uint y)

clamp:
genIType clamp (genIType x, genIType minVal, genIType maxVal)
genIType clamp (genIType x, int minVal, int maxVal)
genUType clamp (genUType x, genUType minVal, genUType maxVal)
genUType clamp (genUType x, uint minVal, uint maxVal)

This is also one of the reason why below dEQP tests are failing with error "no 
matching overloaded function found":
- Tests in : 
dEQP-GLES3.functional.shaders.constant_expressions.builtin_functions.common.*
- Some tests in : dEQP-GLES3.functional.shaders.operator.common_functions.*

Original issue reported on code.google.com by apat...@nvidia.com on 12 Feb 2015 at 11:52

GoogleCodeExporter commented 9 years ago
I have started looking into this and will upload a patch once I have it ready.

Original comment by apat...@nvidia.com on 12 Feb 2015 at 11:53

GoogleCodeExporter commented 9 years ago

Original comment by oetu...@nvidia.com on 12 Feb 2015 at 12:05

GoogleCodeExporter commented 9 years ago
Uploaded patch for review : https://chromium-review.googlesource.com/#/c/250330/

Original comment by apat...@nvidia.com on 17 Feb 2015 at 3:58

GoogleCodeExporter commented 9 years ago
Patch is merged, someone having an access, please close this bug.

Original comment by apat...@nvidia.com on 18 Feb 2015 at 4:09

GoogleCodeExporter commented 9 years ago

Original comment by oetu...@nvidia.com on 18 Feb 2015 at 12:22