Changing the workbench license

[prokoudine]

The Workbench Creation guide recommends licensing addons under the terms of LGPL2.1 — the same license that FreeCAD source code is available under. The recommendation’s rationale is that it should be possible to ship a FreeCAD distribution, either upstream, or a custom one, with 3rd-party addons that are considered useful. While a workbench developer is free to choose an alternative license, doing so may impact the long-term viability and use of the workbench and should be considered carefully.

Ondsel would like to integrate the Fasteners workbench into its distribution of FreeCAD, because the company’s market study suggests that this feature is expected to be available in 3D CAD programs by default. We want to provide our end-users the best possible experience. There’s a possibility that this workbench then will go back to become part of upstream FreeCAD. However neither the upstream version of FreeCAD, nor Ondsel’s version of FreeCAD can distribute this workbench as long as it’s licensed under the terms of GPL2.

We are asking for a conversation about relicensing this workbench under LGPL2+ or another compatible license to allow wider distribution.

• [X] @shaise
• [X] @alexneufeld
• [X] @riqueenz
• [ ] @FreeCAD-Tools
• [X] @luzpaz
• [X] @hasecilu
• [x] @berberic2
• [X] @Roy-043
• [ ] @EA32
• [x] @elysium31
• [X] @kaktusus
• [X] @wavexx
• [X] @tobiasfalk
• [X] @easyw
• [X] @fra589
• [X] @wandrewkeech
• [X] @algtgv
• [X] @hpbmo
• [X] @chennes
• [X] @ApexArray
• [X] @JohanAR
• [x] @elf128
• [X] @chrido
• [X] @spike77453
• [X] @yorikvanhavre
• [X] @f3nix

[alexneufeld]

I have no issues with the idea of doing this. Taking a quick look through the repository contributors list, I'd say there's a good chance we can get everyone to sign off on a license change to LGPL. I agree that this change fits well within the philosophy of the FreeCAD project.

For potentially useful reference: I like the approach the MPV player developers took to tackling this exact problem: https://github.com/mpv-player/mpv/issues/2033

[prokoudine]

@alexneufeld That's a really useful reference, thank you!

[shaise]

I'm all for re-licensing to LGPL2.1, this is also compatible with @ulrich1a screw_maker license which the original WB was based on.

[shaise]

waiting for response of: @riqueenz, @FreeCAD-Tools, @luzpaz, @hasecilu, @berberic2, @Roy-043, @EA32, @elysium31, @kaktusus, @wavexx, @tobiasfalk, @easyw, @fra589, @wandrewkeech, @algtgv, @hpbmo, @chennes, @ApexArray, @JohanAR, @elf128, @chrido, @spike77453, @yorikvanhavre, @f3nix

[kaktusus]

I've been working on the Polish translation of this cool workbench, and I don't mind changing the license. :smile:

[Roy-043]

I have no objections to the LGPL2.1 license.

[hpbmo]

I have also no objections to the LGPL2.1 license.

[wavexx]

Thanks for pinging, I wouldn't have noticed otherwise. No objection to the license change!

[fra589]

Hi all,
I just made an action to correct a bug linked to the evolution of Python and FreeCAD, I do not feel entitled to decide on the licensing level... Do as your wish :-) Thanks for your work!

[hasecilu]

Thanks for ping, it's nice to know that this WB could join upstream FreeCAD. I agree with the license change, I'm also in for SheetMetal WB.

[tobiasfalk]

In my opinion, my share of contribution is rather small and do not think that I would have a saying in this. But I do not have a problem with this.

@prokoudine will there be an other Issue/Thread where one could give Suggestion of features that would be nice if they where implemented in this move to an Integrated workbench? This is since the most intelligent think to do, while moving this to FreeCAD, is to rewrite the core of this workbench in C++/Qt.

[prokoudine]

@tobiasfalk I could be talking out of my arse, but I vaguely recall that @sliptonic and @shaise were in agreement that the unfolder shoud definitely be part of the core and thus be rewritten in C++. Once/if the relicensing of both WBs has green lights, there definitely should be review of both architecture, workflow, and UX/UI to come up with a sensible plan.

[riqueenz]

No objection to the license change!

[tobiasfalk]

And can either @prokoudine or @shaise make a check list with all the pinged people to make it easier to look up who already agreed?

• [ ] A
• [x] B
• [ ] ....

[hasecilu]

(Copy the main post)

- [X] @shaise
- [X] @alexneufeld
- [X] @riqueenz
- [ ] @FreeCAD-Tools
- [ ] @luzpaz
- [X] @hasecilu
- [ ] @berberic2
- [X] @Roy-043
- [ ] @EA32
- [ ] @elysium31
- [X] @kaktusus
- [X] @wavexx
- [X] @tobiasfalk
- [ ] @easyw
- [X] @fra589
- [ ] @wandrewkeech
- [ ] @algtgv
- [X] @hpbmo
- [ ] @chennes
- [ ] @ApexArray
- [ ] @JohanAR
- [ ] @elf128
- [ ] @chrido
- [ ] @spike77453
- [ ] @yorikvanhavre
- [ ] @f3nix

[shaise]

@hasecilu, Thanks! great idea!

[spike77453]

Works for me! :+1:

[ApexArray]

No objections here 👍

On Thu, Dec 7, 2023 at 9:35 AM spike77453 @.***> wrote:

Works for me! 👍

— Reply to this email directly, view it on GitHub https://github.com/shaise/FreeCAD_FastenersWB/issues/307#issuecomment-1845666702, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV3VF6XLO7EWJU7BVXKGTQDYIHV6BAVCNFSM6AAAAABAIGPZR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBVGY3DMNZQGI . You are receiving this because you were mentioned.Message ID: @.***>

[f3nix]

I do not mind the change. Cheers, Mateusz

[algtgv]

No objection to the license change!

[chennes]

No objection to the license change (and I think distributing this with FreeCAD would be a good idea :) )

[chrido]

No objections to the license change :+1:

[JohanAR]

No objections, I'm barely a contributor to this project anyway :)

[JMG1]

No objections.

[luzpaz]

No objection

[berberic2]

That is O.K. for me.

[yorikvanhavre]

Sorry to be late :sweat_smile: I agree!

[easyw]

go for it! sorry being late, but I don't watch very often my GH notifications

[berberic2]

FYIO: What git blame thinks about the missing user. This is not a comprehensive analysis!

EA32 419 lines in 18 files
    GrammaticalTools.py:25
    InitGui.py:1
    FsData/gost1144head.csv:42
    FsData/gost1144length.csv:2
    FsData/gost1144range.csv:2
    FsFunctions/FSmakeWoodScrew.py:104
    Icons/ASMEB18.2.1.6.svg:14
    Icons/ASMEB18.21.1.12B.svg:11
    Icons/ASMEB18.3.5C.svg:12
    Icons/DIN508.svg:26
    Icons/GN507.svg:49
    Icons/GOST1144-3.svg:33
    Icons/GOST1144-4.svg:33
    Icons/ISO4014.svg:14
    Icons/ISO4028.svg:12
    Icons/ISO7089.svg:11
    Icons/ThreadedRod.svg:14
    Icons/ThreadedRodInch.svg:14

FreeCAD-Tools 1922 lines in 34 files
    TRANSLATIONS.md:73
    GrammaticalTools.py:41
    FastenerBase.py:29
    FastenersCmd.py:35
    README.md:4
    ScrewMaker.py:2
    translations/fasteners_pt-br.ts:182
    translations/fasteners_pt-pt.ts:182
    translations/fasteners_ru.qm:39
    translations/fasteners_ru.ts:885
    translations/update.sh:43
    translations/fasteners_es-ar.ts:137
    translations/fasteners_es-es.ts:137
    FsData/DiaList.csv:2
    FsData/din571length.csv:19
    FsData/gost1144length.csv:29
    FsData/gost1144range.csv:22
    FsData/gost11860def.csv:15
    FsFunctions/FSmakeCupNut.py:1
    FsFunctions/FSmakeWoodScrew.py:1
    Icons/ASMEB18.3.1A.svg:17
    Icons/ASMEB18.3.5A.svg:11
    Icons/ASMEB18.3.5B.svg:11
    Icons/ASMEB18.5.2.svg:13
    Icons/DIN96.svg:16
    Icons/GOST1144-1.svg:19
    Icons/GOST1144-2.svg:19
    Icons/GOST11860-1.svg:12
    Icons/ISO4026.svg:11
    Icons/ISO4027.svg:11
    Icons/ISO4762.svg:16
    Icons/PCBSpacer.svg:17

elysium31 0 lines in 0 files 0

wandrewkeech 0 lines in 0 files

elf128 0 lines in 0 files

[elf128]

Hey, sorry for late replly. I'm ok with the change.

Dec 7, 2023 08:44:44 Shai Seger @.***>:

waiting for response of: @riqueenz[https://github.com/riqueenz], @FreeCAD-Tools[https://github.com/FreeCAD-Tools], @luzpaz[https://github.com/luzpaz], @hasecilu[https://github.com/hasecilu], @berberic2[https://github.com/berberic2], @Roy-043[https://github.com/Roy-043], @EA32[https://github.com/EA32], @elysium31[https://github.com/elysium31], @kaktusus[https://github.com/kaktusus], @wavexx[https://github.com/wavexx], @tobiasfalk[https://github.com/tobiasfalk], @easyw[https://github.com/easyw], @fra589[https://github.com/fra589], @wandrewkeech[https://github.com/wandrewkeech], @algtgv[https://github.com/algtgv], @hpbmo[https://github.com/hpbmo], @chennes[https://github.com/chennes], @ApexArray[https://github.com/ApexArray], @JohanAR[https://github.com/JohanAR], @elf128[https://github.com/elf128], @chrido[https://github.com/chrido], @spike77453[https://github.com/spike77453], @yorikvanhavre[https://github.com/yorikvanhavre], @f3nix[https://github.com/f3nix]

— Reply to this email directly, view it on GitHub[https://github.com/shaise/FreeCAD_FastenersWB/issues/307#issuecomment-1845368583], or unsubscribe[https://github.com/notifications/unsubscribe-auth/ABOXE3OMXSDKQPODYZO4LQTYIHB4XAVCNFSM6AAAAABAIGPZR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBVGM3DQNJYGM]. You are receiving this because you were mentioned. [Tracking image][https://github.com/notifications/beacon/ABOXE3NFSSEY423KIDK7KILYIHB4XA5CNFSM6AAAAABAIGPZR6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTN7YLQO.gif]

[shaise]

@berberic2 , I do not know how blame works but @elysium31 had several PRs. @wandrewkeech and @elf128 had one. Perhaps their work was overwritten? Even so, they still count. waiting for @FreeCAD-Tools and @ea32 as well

[berberic2]

As I said: This is not a comprehensive analysis! blame gives for every line the last user that commited this line, so changing the indentation or whitespaces is sufficient.

[elf128]

@elf128 is me. And, like I sad, I'm ok, with the change. Once again, sorry, for late respose.

Dec 23, 2023 09:28:33 Shai Seger @.***>:

@berberic2[https://github.com/berberic2] , I do not know how blame works but @elysium31[https://github.com/elysium31] had several PRs. @wandrewkeech[https://github.com/wandrewkeech] and @elf128[https://github.com/elf128] had one. Perhaps their work was overwritten? Even so, they still count. waiting for @FreeCAD-Tools[https://github.com/FreeCAD-Tools] and @EA32[https://github.com/EA32] as well

— Reply to this email directly, view it on GitHub[https://github.com/shaise/FreeCAD_FastenersWB/issues/307#issuecomment-1868305452], or unsubscribe[https://github.com/notifications/unsubscribe-auth/ABOXE3OGUHGVSEAX6VT4LB3YK3TBDAVCNFSM6AAAAABAIGPZR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRYGMYDKNBVGI]. You are receiving this because you were mentioned. [Tracking image][https://github.com/notifications/beacon/ABOXE3ILW66Y6NFNS5WYLJ3YK3TBDA5CNFSM6AAAAABAIGPZR6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTPLQKCY.gif]

[shaise]

@elf128 , thanks! noted! @berberic2 , as I said perhaps their lines are no longer in the code, but they did contribute.

[sliptonic]

If their changes are still there, we would proceed by removing them. So If their code changes are no longer present than we can proceed without their reply.

[kaktusus]

@FreeCAD-Tools is a man from Ukraine. We all know the current situation in that country. Give him some time. :disappointed:

[hasecilu]

git shortlog --author=FreeCAD-Tools --author=EA32 --author=elysium --author=keech

Click to view commits

Andy (2): Add IUT[A/B/C] heatset inserts for 3D print modeling Auto-sizing for IUTA/B/C heat sets EA32 (9): GOST1144-3-4 fastener integration SVG icons optimization GOST 1144 head shape fix. Create head by B-Spline SVG icons optimization GOST 1144 (Wood screws) code refactoring Add text converter to singular form SVG icons optimization SVG icons optimization FreeCAD-Tools (49): Full translation to Russian. Update Russian translation. Update Russian translation Added translate to treeview & fix LH flag for nuts Remove obsolete translations Minor Russian translation fixes. Integration of GOST11860 Type 1 Cap Nut DIN571 formating mistakes Add missing DIN7998 screw threads GOST1144 type 1 & type 2 integration Fix Fix2 Update FastenersCmd.py Optimization of the command table. Update translation via Linux bash script Add files via upload Add files via upload Delete fasteners_uifiles_es-ar.qm Delete fasteners_uifiles_es-ar.ts Delete fasteners_uifiles_es-es.qm Delete fasteners_uifiles_es-es.ts Delete fasteners_uifiles_pt-br.qm Delete fasteners_uifiles_pt-br.ts Delete fasteners_uifiles_pt-pt.qm Delete fasteners_uifiles_pt-pt.ts Delete fasteners_uifiles_ru.qm Delete fasteners_uifiles_ru.ts Replace es_mx to es-mx and update script comments Delete fasteners_es_mx.qm Delete fasteners_es_mx.ts Minor fix update.sh Merge branch 'shaise:master' into master Optimize GOST 1144-1-2 and DIN96 SVG icons Fix 48x48px size Size fix PCBSpacer.svg optimization SVG icons optimization Update FastenerBase.py FastenerBase.py separate commands in code Update translation to Russian mx-es removed from list Change Scale B to Offset B Remove unused strings from ts files Remove unused strings from ts files Init Grammatical Tools SVG icons optimization Fix toolbars names Create HOW_TO_ADD_NEW_LANGUAGE.md Updating the article about translation Maksym Veremchuk (10): Fix statements Add some more More Fix indentations Fix imports Fixes Works Merge branch 'master' into fix_indent More Refactor csv2dict

[kaktusus]

@FreeCAD-Tools is a man from Ukraine. We all know the current situation in that country. Give him some time. 😞

Or am I in the wrong?

[wandrewkeech]

Hi! Sorry been afk on github for quite some time. This is great and fully support the license cha!nge

[shaise]

great! Waiting for @FreeCAD-Tools , @EA32 and @elysium31

[elysium31]

No objections

[leoheck]

Pinging @FreeCAD-Tools @EA32

Could you guys comment here if this licence change is ok for you?

[sliptonic]

I think we should post here the intention to change the license unless someone objects. Leave it for 30 days or so and then proceed. If either of the outstanding contributors complains, we can remove their contributions at a later date.

[leoheck]

Why not just make a PR changing it and then if no one complains in by the end of the week. It gets merged, and if the complaints come after this, then their work can be removed as you said. There are just 2 contributors that are missing to respond. In other words, way to wait for a month? This was posted on December 2023.

[sliptonic]

This isn't a huge emergency. Changing the license won't immediately change anything. Before we can consider including the WB in Ondsel or in upstream FreeCAD there's more work to be done and nobody is standing up to do it yet. We have sheetmetal underway and many other important changes to work on.

[tobiasfalk]

@shaise how much amd what did the two missing contribut.

[shaise]

@tobiasfalk Quite a lot...

[leoheck]

@shaise, Have you checked if they are active on GitHub still? They may have died or been jailed...

[shaise]

@leoheck Already checked. They are not active. Really hope not for your proposed reasons...

[tobiasfalk]

Two things. First, I am no expert in Licensing but is this kind of decision somthing that requires approval fromm all or is this something a majority vote can decide? Maybe, @sliptonic you may have more experience or maybe a good connection to a lawyer/licence expert.

Second, they both contributed quite a lot, is that something that is a major part of the WB or can it be easily redone, if a approval of all is required.