search

shaise / FreeCAD_FastenersWB

A workbench to add/attach various fasteners to parts
GNU General Public License v2.0
279 stars 85 forks source link

Change MenuText of fasteners according to grouping mode #363

Open hasecilu opened 5 months ago

hasecilu commented 5 months ago

When the icons are not grouped in drop-down list the tooltip that appears is bloated/redundant, this changes expect to have cleaner tooltips.

image

Fix #355

shaise commented 5 months ago

It looks like mode 2 misses the command name.

hasecilu commented 5 months ago

I think that's the behavior of drop-down group, it was the same even before this change.

shaise commented 5 months ago

Hi, Yes I completely agree with the changes to mode 0 and 1. regarding mode 2, I don't think we need the help line because its a copy of the menu line. perhaps we need to just show the type + command name? i.e. ISO 4014 (FSISO4014) What do you think?

hasecilu commented 5 months ago

Do you know how to fix this? Could happen with other languages. When the tooltip is "" I think the MenuText is copied to ToolTip. image

Something like this? image

shaise commented 5 months ago

  1. There is an issue with the tooltip in mode 2: when first time you point on the icon it shows title tooltip, but as soon as you select any fastener, the to tooltip changes. Dont know how to solve this.

  2. I want to show the command for script usage (same as other modes) so un this case it will be FSDIN653

hasecilu commented 5 months ago

My main concern was the accent that was being not rendered correctly.

It seems in the previos image the second line was not the tooltip, is the "command", I remembered, when the tooltip is the same as the menutext it's hidden. The last line is the command, it's in italic, and I suppose from FreeCAD is not expected to have accents.

image

This happens in the menu in Mode 2, somewhat bloated image

VS mode 0, 1 image

shaise commented 5 months ago

this is strange, I dont have this issue in mode 2: image

hasecilu commented 5 months ago

Try "Nut" group

shaise commented 5 months ago

Yes, there are too many nuts. We need to separate nuts to several groups, or find a new way to add fasteners.

hasecilu commented 5 months ago

Could be split on: "Hexagonal nuts", "Flange nuts", "Square nuts", "Cap nuts", "Wing castles", "Castle nuts" OR "Hexagonal nuts" and "Non Hexagonal nuts"

czinehuba commented 5 months ago

How about a different approach then separate commands in the toolbar. Fusion recently introduced a nice feature. The filtering and selecting it from three view looks really streamlined.

https://www.autodesk.com/products/fusion-360/blog/autodesk-fusion-fasteners-library/

hasecilu commented 5 months ago

I think that major changes that impact on UI/UX should wait a time to see if FreeCAD improves the UI/UX and creates new guidelines for a better consistency.

I like the "stack" approach to attach washer and nut to a bolt, maybe in the future.

shaise commented 5 months ago

I think that major changes that impact on UI/UX should wait a time to see if FreeCAD improves the UI/UX and creates new guidelines for a better consistency.

Yes, indeed I agree.

hasecilu commented 5 months ago

What changes are still needed here?

shaise commented 5 months ago

In my opinion, no matter how we arrange the toolbar, with more and more fasteners, we will always reach a limit where the usability will be bad. I think that ultimately there should be a single Add button that opens a task with a tree of fasteners. But I will wait for the stabilization of freecad's ui/ux and perhaps get some ideas from the DWG team.

hasecilu commented 5 months ago

And regarding the tooltips, does they need tweaks? The "bloated" menus on mode 2 is a secondary effect of the grouping, I think users will, most of the times, prefer to create their fasteners using the button menus rather than using the menus, so it's kind of "hidden" for them.

czinehuba commented 5 months ago

The tree view with just one button is a great idea.....