shaise / FreeCAD_FastenersWB

A workbench to add/attach various fasteners to parts
GNU General Public License v2.0
279 stars 85 forks source link

Discard unneeded int casts in getStandardButtons methods #366

Closed YakoYakoYokuYoku closed 5 months ago

YakoYakoYokuYoku commented 5 months ago

Because QtWidgets.QDialogButtonBox.StandardButtons are already converted into ints in FreeCAD's Gui::TaskDialogPython::getStandardButtons, such conversions in workbench code aren't needed. Also this fixes compatibility with PySide6.

https://github.com/FreeCAD/FreeCAD/blob/b9bfa5c5507506e4515816414cd27f4851d00489/src/Gui/TaskView/TaskDialogPython.cpp#L736-L754

shaise commented 5 months ago

Thanks!