search

shaise / FreeCAD_FastenersWB

A workbench to add/attach various fasteners to parts
GNU General Public License v2.0
284 stars 86 forks source link

Install ulrich1a screw_maker Macro as Python Package #55

Open gbroques opened 4 years ago

gbroques commented 4 years ago

I created an issue in @ulrich1a screw_maker repository to publish the package on The Python Package Index (PyPI) so the Fasteners workbench can simply install it rather than maintain a copy-pasted file.

The FreeCAD Workbench Starter Kit has some discussion on how to do this, and some example projects using this pattern.

See Using pip and uploading your package to pypi sections in the README of the Workbench Starter Kit.

Any thoughts on this proposal?

luzpaz commented 4 years ago

@gbroques better to open a thread on the forum to discuss this. It will gain more traction than here.

Edit: Please past URL of thread when you do so we can track it from this issue.

gbroques commented 4 years ago

@luzpaz Thanks for steering me in the right direction, as I'm still very new to FreeCAD and the community.

I'll do this for future issues I create on FreeCAD GitHub repositories as it seems to be preferred by FreeCAD developers.

For now, I'm focused on ose-3d-printer-workbench, and not very interested in putting forth the effort to move this or other issues I raised on this repository forward. (although, I think they're good ideas still)

(I'm comfortable with @shaise leaving this open, closing any issue I opened, or whatever he wants to do with suggestions I raise)

luzpaz commented 2 years ago

@ulrich1a is unresponsive. maybe it's time to just consider this WB a legit fork and start refactoring it because screw_maker macro is enormous and would really benefit from it?

gbroques commented 2 years ago

@ulrich1a is unresponsive. maybe it's time to just consider this WB a legit fork and start refactoring it because screw_maker macro is enormous and would really benefit from it?

That makes sense to me.

I'll go ahead and close this issue.

luzpaz commented 2 years ago

Disagree, should keep this open since this a legit feature request

shaise commented 2 years ago

the WB version is far from being a copy-pasted version. It was too specific to be used as a general library, so there are lots of changes. Each time the macro was updated I had to manually apply all the changes. Right now it is so different, that this method is no longer possible at all.

luzpaz commented 2 years ago

I wish @ulrich1a would be inspired to hack on this workbench directly

shaise commented 2 years ago

Well, he is marked as a collaborator...

gbroques commented 2 years ago

the WB version is far from being a copy-pasted version. It was too specific to be used as a general library, so there are lots of changes. Each time the macro was updated I had to manually apply all the changes. Right now it is so different, that this method is no longer possible at all.

Thanks shaise, that helps clarify things.

@luzpaz @shaise Should we close this issue then?