search

shaise / FreeCAD_SheetMetal

A simple sheet metal workbench for FreeCAD
http://theseger.com/projects/2015/06/sheet-metal-addon-for-freecad/
GNU Lesser General Public License v2.1
196 stars 56 forks source link

Flatten with arcs failing #203

Open mike-ccs opened 3 years ago

mike-ccs commented 3 years ago

Hi Developers I use the sheetmetal with great results to flatten various designs and highly recommend it. Thank you. In my PCB design I add a layer that has the details for cutouts of connectors holes etc. I then export this and import into a sketch. This I then apply the close endpoints in the sketcher and cut the holes on the desired face.

I have found a bug that occurs when "two arcs" or "arc and line" are used to create a closed shape, eg a crescent moon, keyed hole for connector, the Unfolding is failing dialog box. Adding constraints does not make a difference. If the offending shape is removed then the flatten works as expected. Other shapes tested: 4 lines, circle, B-spline(teardrop), Oblong 2 arcs 2 lines, 2 arc 1 line, all work correctly.

In the attached Fcd the fault is present. the "D" and "crescent moon" cause the error.

SheetMeta_2_48_Arc_Bug.zip Sheet_Mtal_2_48_Arcs_Error SheetMeta_2_48_Arc_Bug.log

Look forward to some resolution. Thank you

shaise commented 3 years ago

The unfold function is based on an external unfold script. It is known to fail at some circumstances.

luzpaz commented 3 years ago

@jaisekjames care to weigh in ?

luzpaz commented 3 weeks ago

ping @jaisekjames (any chance you can weigh-in ?