Revert "Fix typo "Substraction" not "Subtraction""

shaise / FreeCAD_SheetMetal

A simple sheet metal workbench for FreeCAD

http://theseger.com/projects/2015/06/sheet-metal-addon-for-freecad/

GNU Lesser General Public License v2.1

193 stars 56 forks source link

Revert "Fix typo "Substraction" not "Subtraction"" #241

Closed akshimassar closed 2 years ago

akshimassar commented 2 years ago

This reverts commit fef6bb2d310c8f8acc62b242ec8bad54385139e4. See #240

shaise commented 2 years ago

I just investigated why useSubtraction produced an error for issue #238, and it seems he was trying to load and old file that used the useSubstruction wrong spelling. so perhaps an old version of sheetmetal used the old spelling, and now is incompatible with the new version. I will fix it to support both.

luzpaz commented 2 years ago

Any traction on this?

shaise commented 2 years ago

I have already fixed it, it now supports both old files and new ones. I did not use this PR since this PR will not be backward compatible

luzpaz commented 2 years ago

Thanks. Closing this PR then