shaise / FreeCAD_SheetMetal

A simple sheet metal workbench for FreeCAD
http://theseger.com/projects/2015/06/sheet-metal-addon-for-freecad/
GNU Lesser General Public License v2.1
193 stars 56 forks source link

Feature: Simple way to make hems #302

Open pierreporte opened 6 months ago

pierreporte commented 6 months ago

Hems are often used in sheet metal. There are several kinds of hem (see picture below). Most of them can be done using SMMakeWall and maths to compute the right parameters. The rolled hem isn’t possible right now because it needs the leg length to be zero.

Commands for hem can inherit SMMakeWall and do some calculations to determine the bend radius and leg length. Here is a document with all the formulas: sheetmetal hems.pdf. I have not described the rope hem because it needs two flanges so it is a more complex object.

image

pierreporte commented 6 months ago

The following page gives some potential defaults for this feature: https://xometry.eu/en/design-tips-sheet-metal-bending/

image

image

pierreporte commented 6 months ago

I tried to find my way in the code to see if I could do something but I am not a programmer (I just know some Python). Is there some documentation that explains how the workbench works internally?

shaise commented 6 months ago

I'm true;y sorry, no document like that. This WB started as a simple addon I made to myself, but then many other programmers contributed to it. So there is no design doc to the code. I do think this feature can be nice, I might go for it once I have time

pierreporte commented 2 months ago

I’ll try to implement this once PR #335 is merge.