shaise / FreeCAD_SheetMetal

A simple sheet metal workbench for FreeCAD
http://theseger.com/projects/2015/06/sheet-metal-addon-for-freecad/
GNU Lesser General Public License v2.1
204 stars 58 forks source link

Error in "make wall" #311

Closed free777cat closed 7 months ago

free777cat commented 8 months ago

Unexplained error. Зняток екрана як 2024-03-17 18-34-18 Зняток екрана як 2024-03-17 18-33-38 examp.zip

free777cat commented 8 months ago

This is the second project with such an error

shaise commented 8 months ago

@jaisekjames , Can you take a look at it? seems an issue with auto mitering.

free777cat commented 8 months ago

What do you mean?

free777cat commented 8 months ago

Maybe it's these labels?

Зняток екрана як 2024-03-22 17-25-21

===================

Зняток екрана як 2024-03-22 17-25-35

shaise commented 8 months ago

@free777cat ,

What do you mean?

I just asked the original developer of this feature to take a look at the bug. Anyway I took a look myself and I think I know what the problem is. A fix is on the way.

free777cat commented 8 months ago

This is very good. This Error forced me to manually correct very complex details.

shaise commented 8 months ago

@free777cat OK, I believe it is fixed now. please update the workbench and recompute your model. Please let me know if it fixed your issue.

free777cat commented 8 months ago

Зняток екрана як 2024-03-23 23-03-56 Зняток екрана як 2024-03-23 23-05-51 Зняток екрана як 2024-03-23 23-04-42

Many thanks!!! Couldn't figure out what the lilac labels are. Maybe you know? And then let's close it...

free777cat commented 8 months ago

Had to uninstall and reinstall. The update didn't work. That's the only way everything turned out well.

free777cat commented 8 months ago

lilac labels appear when the object has been used in a Boolean operation

shaise commented 8 months ago

What do you mean?

free777cat commented 8 months ago

Sorry. This is a false statement.

free777cat commented 8 months ago

Houston! We have problems again! Please look at this (( examp1.zip

free777cat commented 8 months ago

Зняток екрана як 2024-03-28 17-05-43

free777cat commented 8 months ago

examp1.zip

shaise commented 8 months ago

Yes you are correct. This is limitation of sheetmetal wb - fold works good only on square faces. This will work: image

And this will not work: image

shaise commented 8 months ago

hi @free777cat

I have enhanced the bend function to work on refined faces as well. It should work now in most cases. shai

free777cat commented 8 months ago

Thank you very much!!!!!!!!!!! An important new project was in jeopardy.

free777cat commented 8 months ago

I propose to introduce a new element "workpiece" into the "history tree". This is a virtual element containing the following values: thickness, bending radius, workpiece orientation (in the "sketch" plane or perpendicular). +possibly sheet sizes. For further imitation. It's a lot of code work, but at the beginning I already have this data but it's not marked as "data" in one specific place.

free777cat commented 8 months ago

Just closed and again a strange error (( short video https://youtu.be/BwsipMRXQn8

Зняток екрана як 2024-03-30 10-35-11

free777cat commented 8 months ago

examp2.zip

shaise commented 8 months ago

Yes I noticed that sometimes auto mitering does not work. I will take a look at it, But in this case you should switch off auto mitering because if you flatten the shape you get an invalid sheet.

free777cat commented 8 months ago

watch the video, everything changes there

shaise commented 8 months ago

OK, I found the issue. When auto mitering you must set the max extend value. the default is 5mm. This is good for 2mm sheet but not 5mm. Just change "Max Extend" value to a higher value if you want the mitering to work: image