search

shaise / FreeCAD_SheetMetal

A simple sheet metal workbench for FreeCAD
http://theseger.com/projects/2015/06/sheet-metal-addon-for-freecad/
GNU Lesser General Public License v2.1
190 stars 55 forks source link

Some refactoring on bendsolid. #319

Closed sliptonic closed 4 months ago

sliptonic commented 5 months ago

Some Black() formatting. Renamed some variables to make the code more readable. Some minor refactoring.

Added unit test structure and a unit test for get_point_on_cylinder

shaise commented 4 months ago

Hi @sliptonic

It looks like there are some conflicts. I recently made quite a lot of bug fixing and algorithm changes to sheetmetal, so this might cause the conflicts.

shai

sliptonic commented 4 months ago

Ok. Rebased and cleaned up.
This is mostly minor stuff. variable naming, black(), and a unit test.
Everything works with my test models but could use a double check.

shaise commented 4 months ago

Ok I will take a look. I have added more functionality, this makes bend function work on refined faces as well, and bend solid automatically calculates the thickness. I should add these models as a test case.

shaise commented 4 months ago

Ok. It looks like it works on the new test models as well. I see that you've change the function names and some variables to "Snake Case" Is there a formal naming conversion I should follow? shai