search

shaise / FreeCAD_SheetMetal

A simple sheet metal workbench for FreeCAD
http://theseger.com/projects/2015/06/sheet-metal-addon-for-freecad/
GNU Lesser General Public License v2.1
190 stars 55 forks source link

DWG Review: Create Base Shape Panel #321

Open sliptonic opened 4 months ago

sliptonic commented 4 months ago

Concept panel and tool

baseshapepanel Baseshapetool

shaise commented 4 months ago

This function already have a task panel. comments are appreciated: image note that there is no need for an apply button as every change in the fields of the panel are interactively shown on the part.

maxwxyz commented 4 months ago

My remarks: maybe add an option without a bend. Just to be able to create a flat sheet without the need for a sketch. Also both tools seem to be called base shape (both issues have the exact same name @sliptonic) https://github.com/shaise/FreeCAD_SheetMetal/issues/328 Maybe this tool should keep the base shape name (or something like default/standard presets) and the other could be renamed to Convert to Sheet as it converts wires or closed sketches to a sheet.

shaise commented 4 months ago

Definitely agree for both remarks!

maxwxyz commented 4 months ago

Also, currently you create the feature and need the property editor to change parameters. For all the issues and task dialogs, the idea is that you can double click on the feature in the tree and that same dialog opens and you can adjust the features in the task dialog and save changes.

shaise commented 4 months ago

Yes. This is already the way base shape is done now. Double clicking on it in the tree reopens it and let you make changes.

shaise commented 4 months ago

My remarks: maybe add an option without a bend.

Added

shaise commented 4 months ago

Perhaps we need this dropdown to be images instead of text?

maxwxyz commented 4 months ago

I'm ok with the dropdown, they are descriptive and I think images would be too small on the dropdown scale for such complicated shaped (e.g. hat). Plus it's interactive so you can just change it and see the result.

MisterMakerNL commented 2 days ago

Ok not going to open a new ticket for this but would you be so kind to turn the grid of Qpushbuttons in a grid of Qradiobuttons, that would be waaaaaaaaaay better? IT causes issues with Minimum width of Qpushbuttons that was recommended to me, to set in the stylesheets. image