search

shaise / FreeCAD_SheetMetal

A simple sheet metal workbench for FreeCAD
http://theseger.com/projects/2015/06/sheet-metal-addon-for-freecad/
GNU Lesser General Public License v2.1
204 stars 58 forks source link

Discard unneeded int casts in getStandardButtons methods #333

Closed YakoYakoYokuYoku closed 7 months ago

YakoYakoYokuYoku commented 7 months ago

Because QtWidgets.QDialogButtonBox.StandardButtons are already converted into ints in FreeCAD's Gui::TaskDialogPython::getStandardButtons, such conversions in workbench code aren't needed. Also this fixes compatibility with PySide6.

https://github.com/FreeCAD/FreeCAD/blob/b9bfa5c5507506e4515816414cd27f4851d00489/src/Gui/TaskView/TaskDialogPython.cpp#L736-L754

shaise commented 7 months ago

Thanks!