search

shaise / FreeCAD_SheetMetal

A simple sheet metal workbench for FreeCAD
http://theseger.com/projects/2015/06/sheet-metal-addon-for-freecad/
GNU Lesser General Public License v2.1
204 stars 58 forks source link

Can we have properties converted to Title Case to match Freecad style? #344

Open leoheck opened 5 months ago

leoheck commented 5 months ago

Hey @shaise nice to meet you here. I did not know that this was also your work. What do you think about updating property names on this Workbench too?

image

shaise commented 5 months ago

Yes, I had a feeling it will come into this. Sheetmetal is a bit more complicated in that matter. But I will take a look as well.

leoheck commented 5 months ago

Yes, I had a feeling it will come into this.

Sorry to give you this much work dude!

luzpaz commented 2 months ago

I guess there would need to be a slow deprecation process whereby the deprecated properties need to be converted by a script for backward compatibility, notify the user that older versions of SheetMetal addon aren't compatible... ?

leoheck commented 2 months ago

What if the priperties are read from the file as case insensitive, and converted to the title case internally. When saving the file, the title case is used?

shaise commented 2 months ago

I think that I will probably end up doing the same as I did in Fasteners. Only reason I postponed it is because I need to see how I merge the changes that were done for Ondsel's sheetmetel.