Base Feature images do not match the color theme of the icons

[leoheck]

Sheet metal toolbar icons are awesome. I just realized that these icons to select the origin of the Base Feature do not match the theme.

What do you think about updating the colors of those images using blue instead?

I would also suggest changing the origin dot/ball with something like and + with arrows but this can be too much, maybe.

[shaise]

Indeed blue will be better and will be done. However I tested with arrows - too small.

[leoheck]

@shaise I am seeing this new way of selecting the origin, it looks nice, but the while thing looks a bit wrong. Is this as you expected?

[shaise]

it is wrong. should look like this:

[shaise]

This is rather strange as in your version the icons exceeds the maximum with which is 28 pixels

[leoheck]

I am going to check on discord if this is due to the OpenDark Theme.

[leoheck]

Maybe the min size property is missing somewhere

[shaise]

its not an opendark issue

[shaise]

I will set the min side as well, but should be related to max size

[leoheck]

This is my version by the way. Which OS are you using? Perhaps this can be different from one OS to another.

OS: Ubuntu 24.04 LTS (ubuntu:GNOME/ubuntu)
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.37898 (Git) AppImage
Build type: Release
Branch: main
Hash: 308013fb975ec3bf0dc5cb616ef76a4095e71cc5
Python 3.11.9, Qt 5.15.13, Coin 4.0.2, Vtk 9.2.6, OCC 7.7.2
Locale: English/United States (en_US)
Installed mods: 
  * POV-Ray-Rendering
  * Assembly4 0.50.12
  * sheetmetal 0.4.20
  * InventorLoader 1.4.0
  * fasteners.backup1718838499.3717518 0.5.23 (Disabled)
  * ose-piping
  * fasteners 0.5.24
  * asm4_disable_version_check_popup
  * fasteners.backup1718509812.8005707 0.5.21 (Disabled)
  * OpenDark 2024.3.13
  * ProDarkThemePreferencePack 1.0.0
  * Render 2024.6.5
  * OpticsWorkbench 1.0.18
  * lattice2 1.0.0
  * kicadStepUpMod

[shaise]

i have updated minimum size as well. please try it (you might need to uninstall/reinstall since i did not update the version)

[leoheck]

Still the same, and there are these pushXX messages, maybe from this wb.

[shaise]

Another possible tweak. Can you try again? (also removed pushXX)

[shaise]

If it does not work, I will try to get a ubuntu machine.

[leoheck]

Prints were removed but the image/button is still the same.

[shaise]

I have set the policy to fixed. can you try again?

[leoheck]

sure! let me check.

[leoheck]

It is still the same.

Perhaps it is a problem with the AppImage package.

[shaise]

Ok I fired up my ubuntu. on build 37574, standard theme it looks like this: On opendark:

So it is definitely an opendark issue but only on linux. Can you switch back to standard theme and check to be sure it is the issue?

[shaise]

@leoheck , another update: Using openTheme (dark) instead of openDark seems to solve the issue (need to uninstall openDark)

Opendark is actually deprecated, so you should move to opentheme anyways.

[leoheck]

This took me time. Yeah, I confirm the light version works.

So the openTheme is the most updated,... this is kind of hard to track. haha thanks. Thanks for your patience.

[shaise]

Yes, With OpenTheme you now have both OpenLight and OpenDark. Directly from the theme drop-down. No need for "Preference Pack" like original OpenDark