shaise / FreeCAD_SheetMetal

A simple sheet metal workbench for FreeCAD
http://theseger.com/projects/2015/06/sheet-metal-addon-for-freecad/
GNU Lesser General Public License v2.1
204 stars 58 forks source link

Cleaning a field result in a temporary error #353

Closed leoheck closed 4 months ago

leoheck commented 4 months ago

Since the Base Feature is updated every time the user updates the input field, cleaning them results in an error. I guess, Freecad does a bit differently when updating fields. It waits until the focus leaves from the field. I wouldn't say I like this much but it is better than throwing an error on the Report view. However, sheetmetal could wait until there is a valid value there to recalculate. What do you think?

This happened when I removed the thickness there to put a new value.

image

shaise commented 4 months ago

You are definitely correct. Thanks for the catch. Should be fixed now.

leoheck commented 4 months ago

How do you manage these things on github? Do you just push to the master without changing the version? Or do you make branches? Package manager does not see updates. But updating manually I am seeing this.

image

leoheck commented 4 months ago

This looks working on the current master, thanks. It is way better without red lines on the console.

shaise commented 4 months ago

I update the package.xml as I was told. Dont know what the addon manager looks at

leoheck commented 4 months ago

Yeah, it took time to update I guess, or maybe because I had changes on my copy of the repo.

shaise commented 4 months ago

You are not the first one to complain, so I guess there is still an issue with that