search

shaise / FreeCAD_SheetMetal

A simple sheet metal workbench for FreeCAD
http://theseger.com/projects/2015/06/sheet-metal-addon-for-freecad/
GNU Lesser General Public License v2.1
204 stars 58 forks source link

Fold Wall doesn't work if sketch is a clone/link #360

Closed heeplr closed 3 months ago

heeplr commented 3 months ago

FreeCAD: 0.22.0dev Sheet Metal WB: 0.4.23 from Addon Manager

First of all let me thank you & all contributors for this awesome project!

I noticed that the "Fold a Wall" icon is disabled, when the sketch containing the fold line is a Link to a sketch (right click sketch in model tree -> Link actions -> Make Link") or the clone of a sketch (Draft WB -> Modification -> Clone).

Only "Make Wall", "Extend Face" and "Sketch On Sheet Metal" are available.

When having multiple bodies that should be folded on the same edge, it's convenient if you can just manage a single folding edge sheet instead of one copy for every body. If Links/Clones would work, all the other sheets would update automatically if the original sheet is changed.

shaise commented 3 months ago

Thanks. I will take a look.

shaise commented 3 months ago

@heeplr , Should be working now. can you update test? If updating does not work, try uninstall then install again this addon

heeplr commented 3 months ago

Sure. Here's a project with two bodies (sheet001 and sheet002), one sketch with a mold line and the linked version of that sketch.

~~I generated the Fold of sheet001 and Sketch-fold like normal: select face, shift-select sketch, hit "Fold a Wall". Everything works. But when I attempt the same thing with sheet002 and Sketch-fold002 (the linked version of Sketch-fold), the symptoms described above appear.~~

fold-linked-sketch.zip

heeplr commented 3 months ago

Just updated to the latest version and everything works like a charm now. Thank you!

heeplr commented 3 months ago

whoops, premature celebration :(

While "Fold a wall" now works with linked sketches, it doesn't work with normal Sketch objects anymore.

It's reproducable by removing the Fold from my previous example and trying to Fold it again. Link works, original Sketch doesn't.

shaise commented 3 months ago

Ooops sorry about that... Please uninstall and reinstall, because I left the same version.