shaise / FreeCAD_SheetMetal

A simple sheet metal workbench for FreeCAD
http://theseger.com/projects/2015/06/sheet-metal-addon-for-freecad/
GNU Lesser General Public License v2.1
204 stars 58 forks source link

Hole missing in bend while folding sheet #367

Closed jaisekjames closed 2 months ago

jaisekjames commented 2 months ago

Fix for below issue. Testing needed. Added below

Now outer face created from outer wire.
then subtract inner faces from outer face.

https://github.com/shaise/FreeCAD_SheetMetal/issues/363

shaise commented 2 months ago

Hi @jaisekjames , Thank you for the fix. However, when I try to fold on a sketch line I get the following error:

21:07:08  pyException: Traceback (most recent call last):
  File "C:\Users\shai\AppData\Roaming\FreeCAD\Mod\FreeCAD_SheetMetal\.\SheetMetalFoldCmd.py", line 396, in execute
    s = smFold(
        ^^^^^^^
  File "C:\Users\shai\AppData\Roaming\FreeCAD\Mod\FreeCAD_SheetMetal\.\SheetMetalFoldCmd.py", line 329, in smFold
    bendsolid = SheetMetalBendSolid.bend_solid(
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\shai\AppData\Roaming\FreeCAD\Mod\FreeCAD_SheetMetal\.\SheetMetalBendSolid.py", line 234, in bend_solid
    wrap_wire = WrapFace(outWire, neutral_radius, axis, normal, zero_vert, center, zero_vert_normal)
                ^^^^^^^^
<class 'NameError'>: name 'WrapFace' is not defined
21:07:08  Fold: name 'WrapFace' is not defined