shaj13 / go-guardian

Go-Guardian is a golang library that provides a simple, clean, and idiomatic way to create powerful modern API and web authentication.
MIT License
543 stars 55 forks source link

starttls on 389 requires ldap scheme #114

Closed m87carlson closed 2 years ago

m87carlson commented 2 years ago

Hello!

Using the ldaps scheme against an LDAP server running on port 389, with StartTLS, will result is a "Network Error": read tcp x.x.x.x:60677->x.x.x.x:389: read: connection reset by peer error

I believe this should still be scheme ldap, and ldaps should be used against an LDAP server with SSL enabled on port 636.

shaj13 commented 2 years ago

@m87carlson not sure what this PR fix? you have changed the whole project. kindly stop pushing fork to here.

shaj13 commented 2 years ago

@m87carlson please create issue, so we can discuss it there.

m87carlson commented 2 years ago

Oh I apologize, my PR was for one simple change, the other updates were just so I could get everything to build. I will make an issue now.