search

shajen / rtl-sdr-scanner-cpp

GNU General Public License v3.0
604 stars 61 forks source link

Fixed rtlsdr detection and added multi-stage Dockerfile #11

Closed dubrsl closed 1 year ago

dubrsl commented 1 year ago

In this PR was added cmake/FindRTLSDR.cmake for fix this warning:

CMake Warning (dev) at /usr/share/cmake-3.22/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
  The package name passed to `find_package_handle_standard_args` (PkgConfig)
  does not match the name of the calling package (rtlsdr).  This can lead to
  problems in calling code that expects `find_package` result variables
  (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  /usr/share/cmake-3.22/Modules/FindPkgConfig.cmake:99 (find_package_handle_standard_args)
  /usr/lib/x86_64-linux-gnu/cmake/rtlsdr/rtlsdrConfig.cmake:1 (include)
  CMakeLists.txt:11 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

Also added multi-stage Dockerfile. I build rtlsdr from the https://github.com/krakenrf/librtlsdr, because it contains necessary changes for krakenSDR

shajen commented 1 year ago

Multi-stage single Dockerfile is great solution, thanks for it!

What is the advantage of krakenrf over original libsdr?

dubrsl commented 1 year ago

What is the advantage of krakenrf over original libsdr?

https://github.com/librtlsdr/librtlsdr/compare/master...krakenrf:librtlsdr:master

It was disabled some filter which causes phase distortion. And added one function required for krakrensdr (rtlsdr_set_sample_freq_correction_f) If I understood correctly. Probably it is not used and is not needed here.