search

shaka-project / express-chocolatey-server

Simple Chocolatey package server for Express
5 stars 5 forks source link

fix: XML escape package description #3

Closed mwegrzynek closed 11 months ago

mwegrzynek commented 11 months ago

Packages with characters not legal in XML (for example &) in package description are rejected by Cholatey client, with malformed XML message. This pull request fixes that.

google-cla[bot] commented 11 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

joeyparrish commented 11 months ago

@mwegrzynek, thank you for the fix! There are two issues that we need to resolve:

  1. You need to sign the Contributor License Agreement (see the bot comment above). This is Google bureaucracy, and I can't do anything about it.
  2. You need to add xml-escape to the dependencies with npm install xml-escape and then add package.json and package-lock.json to your PR.

Thanks!

mwegrzynek commented 11 months ago

Done!

joeyparrish commented 11 months ago

Published to NPM. Thanks for contributing!