Closed dudewheresmycode closed 5 months ago
I see that support for description
specifically was added in this commit, so I'm guessing this just hasn't made it into a release yet? Any chance you could tag a new release?
Just wanted to check in on this. Any chance we can get a new release tagged that contains this fix?
Just wanted to bump this again. Any chance we could get a new release tagged? The fix for this was merged nearly a year ago now.
version 3.0.x should contain anything that was previously merged, I'll look at adding any missing values
System info
Operating System: Debian GNU/Linux 11 (bullseye) Shaka Packager Version:
shaka-packager version v2.6.1-634af65-release
Issue and steps to reproduce the problem
I'm running into an issue setting the
roles
stream descriptor option for content containing descriptive audio tracks. The DASH spec specifically defines these as:From the
shaka-packager
docs, it appears it only supports a subset of the values outlined in the DASH specification:However, checking the DASH (ISO/IEC 23009-1) specification, section 5.8.5.5 DASH role scheme (Table 29), defines many more values for the roles:
caption
subtitle
main
alternate
supplementary
commentary
dub
description
sign
metadata
enhanced-audio-intelligibility
emergency
Packager Command:
Extra steps to reproduce the problem? (1) include
roles=description
in DASH stream descriptor optionsWhat is the expected result? Generates a DASH manifest with a
description
roleWhat happens instead? Shaka throws an error: