Closed dooafus closed 5 months ago
I'd like to know how commas are supposed to be escaped in stream descriptors too.
perhaps it's not possible to use commas there. packager uses the base::SplitStringIntoKeyValuePairs
function for parsing stream descriptors and it doesn't seem to check for an escape character
That's correct, commas are not supported in stream descriptors.
System info
Operating System: Windows or Linux (tested on both) Shaka Packager Version: 2.6.1 (on both)
Issue and steps to reproduce the problem
Packager Command:
packager in="test,comma.mp4" --dump_stream_info
orpackager in='test,comma.mp4' --dump_stream_info
orpackager in=test,comma.mp4 --dump_stream_info
All variations result in the error:
ERROR:stream_descriptor.cc(106)] Invalid stream descriptors name/value pairs: in="test,comma.mp4"
Also tested on:
playlist_name="test,comma.m3u8"
init_segment="test,comma.init.mp4"
segment_template="test,comma.$Number$.m4s"
Commas do not break the parser for:
--mpd_output "test,comma.mpd"
(working OK)--hls_master_playlist_output "test,comma.m3u8"
(working OK)