shaka-project / shaka-packager

A media packaging and development framework for VOD and Live DASH and HLS applications, supporting Common Encryption for Widevine and other DRM Systems.
https://shaka-project.github.io/shaka-packager/
Other
1.95k stars 504 forks source link

Packager doesn't handle subtitle tracks inside MP4 files (IMSC1) #1215

Open duggaraju opened 1 year ago

duggaraju commented 1 year ago

System info

Operating System: all Shaka Packager Version: v2.6.1-634af65-release

Issue and steps to reproduce the problem

Packager Command: packager-win-x64.exe "in=sample.mp4" --dump_stream_info [0607/173210:INFO:demuxer.cc(89)] Demuxer::Run() on file 'English.cmft'. [0607/173211:INFO:demuxer.cc(155)] Initialize Demuxer for file 'English.cmft'.

File "sample.mp4": Found 0 stream(s). Extra steps to reproduce the problem? (1) (2)

What is the expected result? The subtitle track is recognized.

What happens instead?

in bool MP4MediaParser::ParseMoov(BoxReader* reader) in mp4_media_parser.cc We only handle kAudio/kVideo track types. kSubtitle tracks are ignored. <Please attach the input files or email to shaka-packager-issues@google.com.>

duggaraju commented 1 year ago

https://github.com/shaka-project/shaka-packager/assets/3238784/37630835-7032-469c-9508-d910bf67e48e