fix: Fix failure on very short WebVTT files

shaka-project / shaka-packager

A media packaging and development framework for VOD and Live DASH and HLS applications, supporting Common Encryption for Widevine and other DRM Systems.

https://shaka-project.github.io/shaka-packager/

Other

2k stars 510 forks source link

fix: Fix failure on very short WebVTT files #1216

Closed x-projs closed 1 year ago

x-projs commented 1 year ago

Fix a bug that if the webvtt file is very short, e.g. only contains one block

WEBVTT

00:00:00.500 --> 00:00:02.000
The Web is always changing

shaka packager will report error: "Packaging Error: 6 (END_OF_STREAM)".

Fixes #1217

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

joeyparrish commented 1 year ago

I believe the test failures on Linux are those fixed by #1226, and the Windows and Mac failures are aging build systems and scripts which are all being replaced in the cmake branch. Merging as-is.