shaka-project / shaka-packager

A media packaging and development framework for VOD and Live DASH and HLS applications, supporting Common Encryption for Widevine and other DRM Systems.
https://shaka-project.github.io/shaka-packager/
Other
2k stars 510 forks source link

test: Fix bad assertions in formats/mp4 and formats/mp2t tests #1247

Closed joeyparrish closed 1 year ago

joeyparrish commented 1 year ago

PR #1242 introduced some bad assertions that went unnoticed because we are not yet building those modules in the cmake branch. This fixes those so that ASSERT macros are not used in non-void functions, and so that assumptions about a successful parse are always after an ASSERT that the data was loaded properly.

All ASSERT_ macros from #1242 were audited, and the others were all fine.