fix: apply cmake fixes after merge of #1210

shaka-project / shaka-packager

A media packaging and development framework for VOD and Live DASH and HLS applications, supporting Common Encryption for Widevine and other DRM Systems.

https://shaka-project.github.io/shaka-packager/

Other

2k stars 510 forks source link

fix: apply cmake fixes after merge of #1210 #1264

Closed cosmin closed 1 year ago

cosmin commented 1 year ago

build in CMake branch is broken at least locally on OS X after #1210 was merged which introduced some new warnings and reintroduced base::nullopt.

joeyparrish commented 1 year ago

There are a couple failures on ArchLinux building in docker. I'll try to take a look and offer a fix.