Closed M4urici0GM closed 6 months ago
Hey buddy, thanks for the answer using this version i get a different error: 😭
gclient sync -r v2.6.1
________ running 'git -c core.deltaBaseCacheLimit=2g clone --no-checkout --progress https://github.com/shaka-project/shaka-packager.git /private/tmp/shaka_packager/_gclient_src_hwshbn2z' in '/private/tmp/shaka_packager'
Cloning into '/private/tmp/shaka_packager/_gclient_src_hwshbn2z'...
remote: Enumerating objects: 685775, done.
remote: Counting objects: 100% (3052/3052), done.
remote: Compressing objects: 100% (1181/1181), done.
remote: Total 685775 (delta 2097), reused 2660 (delta 1871), pack-reused 682723
Receiving objects: 100% (685775/685775), 561.74 MiB | 13.54 MiB/s, done.
Resolving deltas: 100% (479539/479539), done.
Syncing projects: 100% (15/15), done.
________ running 'python src/gyp_packager.py --depth=src/packager' in '/private/tmp/shaka_packager'
Traceback (most recent call last):
File "/private/tmp/shaka_packager/src/gyp_packager.py", line 39, in <module>
import gyp_helper
File "/private/tmp/shaka_packager/src/packager/build/gyp_helper.py", line 22
except SyntaxError, e:
^^^^^^^^^^^^^^
SyntaxError: multiple exception types must be parenthesized
Error: Command 'python src/gyp_packager.py --depth=src/packager' returned non-zero exit status 1 in /private/tmp/shaka_packager
Traceback (most recent call last):
File "/private/tmp/shaka_packager/src/gyp_packager.py", line 39, in <module>
import gyp_helper
File "/private/tmp/shaka_packager/src/packager/build/gyp_helper.py", line 22
except SyntaxError, e:
^^^^^^^^^^^^^^
SyntaxError: multiple exception types must be parenthesized
2.6.1 or current main needs Python 2 to build. This is why we are moving to CMake.
Yes, that's right, make sure that python 2 is installed on the system, if you encounter this error again, delete the shaka-packager folder and go through the installation process again.
It's certainly possible to build 2.6 on a ARM based Mac with Python 2, but it is a lot of pain. However the CMake branch ought to build just fine, I'm using an M1 MBP for local development and have no problems building CMake branch with it. So if you have issues building CMake I'm interested in trying to sort that out.
I've tried to build using python 2.7.18
with gsync
and version 2.6.1
but i got an error about the Xcode's SDK version, mine was 10.16
, so i had to download the 10.14, according to the issue #660, but i got a different error. i don't remember the error, i'll try again and pot it here.
Let's keep issues about building CMake and issues about the legacy gyp build separate. In general we are going to consider issues with building gyp on modern MacOS to be unsupported, but can keep the issue open for discussion. However issues about building CMake are very much of interest and would like to get those resolved.
Sure So, ive tried again building with cmake, but without succcess, you can check my entire console log here if helps
My xcode SDks:
ls `xcode-select -p`/Platforms/MacOSX.platform/Developer/SDKs
MacOSX.sdk MacOSX10.14.sdk MacOSX14.0.sdk MacOSX14.sdk
Cmake:
cmake --version
cmake version 3.26.4
Clang:
clang --version
Apple clang version 15.0.0 (clang-1500.0.40.1)
Target: arm64-apple-darwin22.6.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
Previously i was able to build the code editing the code of mbedtls
removing the -Wdocumentation flags from its CMake files, but i think i broke something, since packager wasnt including the segments on mpd file anymore xD
Let me know if you need any more info. :shipit:
Ah, I see the difference, my clang is 14.0.3 and it builds fine with that. It seems to be a regression in clang 15, I think there's a newer version of mbedtls
we can upgrade to which should fix it. I'll look into it.
Fixed by 9b384828c6fa
System info
Operating System:
macOS Ventura 13.6
Shaka Packager Version: using branchcmake
VExtra steps to reproduce the problem? (1)
git clone -b cmake https://github.com/shaka-project/shaka-packager.git --depth 1
(2)git submodule update --init --recursive
(3)cmake -B build -G Ninja -DCMAKE_BUILD_TYPE=Release
(4)cmake --build build --parallel
What is the expected result? Shaka to be built
What happens instead?