Closed Roy-Funderburk closed 9 months ago
A few pointers:
Copyright (c) 2023 Xperi Inc.
in packager/media/codecs/dts_audio_specific_config.h & cc should be Google and not Xperi.We've got some of the changes you recommended done and added to this pull request, and are working on the rest which we plan to also add here.
Thanks for reviewing.
1. Would be a good idea to add unit tests in 2. End to end test in: src/packager/app/test/packager_test.py + create golden files. 4. clang format: git clang-format HEAD^
We are working on the HLS TS support for DTS:X, and we would prefer to submit that as a separate pull request. There are issues there that are not as straightforward as the MP4 additions.
In order to keep code consistent, add support for HLS as well.
Also, please merge with the main
branch, which has undergone significant changes in the recently-completed port to cmake.
Code is merged with the main branch, tests updated and pass.
Also, please merge with the
main
branch, which has undergone significant changes in the recently-completed port to cmake.
feat: Added audio specific configuration udts box to AudioSampleEntry for MP4 input/output. DASH tags for DTS audio as specified in ETSI TS 103 491 and ETSI TS 102 114.
Issue: #1301