shaka-project / shaka-packager

A media packaging and development framework for VOD and Live DASH and HLS applications, supporting Common Encryption for Widevine and other DRM Systems.
https://shaka-project.github.io/shaka-packager/
Other
2k stars 510 forks source link

feat: This patch adds support for DTS:X Profile 2 audio in MP4 files. #1303

Closed Roy-Funderburk closed 9 months ago

Roy-Funderburk commented 11 months ago

feat: Added audio specific configuration udts box to AudioSampleEntry for MP4 input/output. DASH tags for DTS audio as specified in ETSI TS 103 491 and ETSI TS 102 114.

Issue: #1301

sr1990 commented 11 months ago

A few pointers:

  1. Would be a good idea to add unit tests in 
    • packager/media/codecs/dts_audio_specific_config_unittest.cc
    • muxer_listener_internal_unittest.cc
    • box_definitions_unittest.cc
    • xml_node_unittest.cc
  2. End to end test in: src/packager/app/test/packager_test.py + create golden files.
  3. In order to keep code consistent, add support for HLS as well.
  4. clang format: git clang-format HEAD^
  5. Copyright (c) 2023 Xperi Inc. in packager/media/codecs/dts_audio_specific_config.h & cc should be Google and not Xperi.
Roy-Funderburk commented 11 months ago

We've got some of the changes you recommended done and added to this pull request, and are working on the rest which we plan to also add here.

Thanks for reviewing.

1. Would be a good idea to add unit tests in
2. End to end test in: src/packager/app/test/packager_test.py + create golden files.
4. clang format: git clang-format HEAD^
Roy-Funderburk commented 11 months ago

We are working on the HLS TS support for DTS:X, and we would prefer to submit that as a separate pull request. There are issues there that are not as straightforward as the MP4 additions.

In order to keep code consistent, add support for HLS as well.

joeyparrish commented 9 months ago

Also, please merge with the main branch, which has undergone significant changes in the recently-completed port to cmake.

Roy-Funderburk commented 9 months ago

Code is merged with the main branch, tests updated and pass.

Also, please merge with the main branch, which has undergone significant changes in the recently-completed port to cmake.