shaka-project / shaka-packager

A media packaging and development framework for VOD and Live DASH and HLS applications, supporting Common Encryption for Widevine and other DRM Systems.
https://shaka-project.github.io/shaka-packager/
Other
1.9k stars 496 forks source link

chore: Upgrade absl and protobuf #1337

Closed joeyparrish closed 4 months ago

joeyparrish commented 4 months ago

protobuf depends on absl, so both needed an update.

Updating absl fixes issues on Alpine 3.19 (see PR #1327), and also removes the need for hacks around vlog flags.

cosmin commented 4 months ago

Shall we revisit treating warnings as errors in 3rd party deps? It seems like a constant game of whack-a-mole every time we upgrade deps or toolchain.

joeyparrish commented 4 months ago

Yes, I think you're right. At the time I started down this path, I wanted to avoid any surprise warnings that might be meaningful things we should take action on... but third_party is big and we are not really reviewing them.