search

shaka-project / shaka-packager

A media packaging and development framework for VOD and Live DASH and HLS applications, supporting Common Encryption for Widevine and other DRM Systems.
https://shaka-project.github.io/shaka-packager/
Other
1.9k stars 496 forks source link

fix: Fix tags in official Docker images and binaries #1370

Closed joeyparrish closed 3 months ago

joeyparrish commented 3 months ago

The release workflows did not run checkout with fetch-tags: true, so the builds were unable to compute the correct release version number. I audited all instances of actions/checkout to add fetch-tags where needed and clean up unneeded options.

I also had to fix options to docker/build-push-action, which by default ignores actions/checkout and tries to pull from git itself. This led to the Docker build running in a context without the new tag.

Finally, to make verification easier and provide version info in the build logs, this adds debugging info to the version-generation script via stderr.

Closes #1366

joeyparrish commented 3 months ago

See the fix at work here:

$ docker run joeyparrish/shaka-packager-staging:v3.0.4 packager --version
packager version v3.0.4-f52052a-debug